Maniphest T192587

phpcs fail under REL1_28
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Reedy
	Apr 19 2018, 7:25 PM

Description

19:11:29 FILE: /src/maintenance/update.php
19:11:29 ----------------------------------------------------------------------
19:11:29 FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
19:11:29 ----------------------------------------------------------------------
19:11:29  164 | WARNING | Line exceeds 100 characters; contains 134 characters
19:11:29      |         | (Generic.Files.LineLength.TooLong)
19:11:29  165 | WARNING | Line exceeds 100 characters; contains 134 characters
19:11:29      |         | (Generic.Files.LineLength.TooLong)
19:11:29 ----------------------------------------------------------------------
19:11:29 
19:11:29 Time: 3 mins, 20.01 secs; Memory: 146.01Mb

Same code is fine on master (and doesn't fail) on every other branch...

https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-docker/8441/console

Event Timeline

Reedy created this task.Apr 19 2018, 7:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2018, 7:25 PM

Reedy updated the task description. (Show Details)Apr 19 2018, 7:30 PM

We don't do REL1_28 releases any more, do we? 1_27 for the next year, 1_29 for the next couple of months, and 1_30 'til the end of the calendar year. So maybe the jobs aren't properly configured for it?

Meh, just abandon the patches then :)

phpcs fail under REL1_28Closed, DeclinedPublicActions

Description

Event Timeline

phpcs fail under REL1_28
Closed, DeclinedPublic
Actions