Page MenuHomePhabricator

Only show edit summary input box when you can use it
Closed, ResolvedPublic2 Story Points

Description

Motivation
Currently, the FileImporter always shows an edit summary input field, together with a placeholder stating that its contents will only be used if changes were made by the user.
However, this is not ideal, since

  • you should not worry about edit summaries if it won't be saved anyways
  • it does not look well for RTL languages right now, and is potentially introducing erroneous behavior due to its length

Task

  • Only show the edit summary box, when the user has changed either title or file info.
  • This could be the first time on loading the preview page (since the title had to be changed in order to proceed), or any other time it is loaded (because the user decided to edit something)
  • Remove the placeholder
  • It has to work without js

Event Timeline

Lea_WMDE created this task.Apr 23 2018, 8:14 AM
Restricted Application added a project: TCB-Team. · View Herald TranscriptApr 23 2018, 8:14 AM
Lea_WMDE set the point value for this task to 2.Apr 23 2018, 8:14 AM
Lea_WMDE updated the task description. (Show Details)

Change 428686 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Only show edit summary when things changed

https://gerrit.wikimedia.org/r/428686

Change 428686 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Only show edit summary when things changed

https://gerrit.wikimedia.org/r/428686

WMDE-Fisch closed this task as Resolved.May 3 2018, 7:26 AM