Page MenuHomePhabricator

SpecialBlock::getSuggestedDurations should not return 'other' unless if appropriate
Closed, ResolvedPublic

Description

In 3481e3b2e0af @dbarratt modified SpecialBlock::getSuggestedDurations to return an option named 'other' at the end of all other block duration suggestions. While this works well for MW core, he accidentally broke another dependency in AbuseFilter in includes/views/AbuseFilterViewEdit.php

I will make a patch shortly to add an optional variable to getSuggestedDurations to suppress the 'other' option whenever it is not desired.

Details

Related Gerrit Patches:

Event Timeline

Huji created this task.Apr 30 2018, 1:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2018, 1:35 AM

Change 429708 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/core@master] Make the 'other' option superessable in getSuggestedDurations

https://gerrit.wikimedia.org/r/429708

Vvjjkkii renamed this task from SpecialBlock::getSuggestedDurations should not return 'other' unless if appropriate to 3zdaaaaaaa.Jul 1 2018, 1:13 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Huji, Aklapper.
AntiCompositeNumber renamed this task from 3zdaaaaaaa to SpecialBlock::getSuggestedDurations should not return 'other' unless if appropriate.Jul 1 2018, 12:32 PM
AntiCompositeNumber raised the priority of this task from High to Needs Triage.
AntiCompositeNumber updated the task description. (Show Details)

Change 429708 merged by jenkins-bot:
[mediawiki/core@master] Make the 'other' option superessable in getSuggestedDurations

https://gerrit.wikimedia.org/r/429708