| alaa | |
| May 1 2018, 10:32 AM |
| F17485752: capture-20180501-123119.jpg | |
| May 1 2018, 10:32 AM |
/var/www/src/AppBundle/Controller/PagesController.php: 238 - error-pagepile-too-large
URL: http://xtools.wmflabs.org/pages/ar.wikipedia.org/IamIRAQI/all?format=PagePile
XTools version: 3.3.3-24f3f20
Example code using PagePile API: https://bitbucket.org/magnusmanske/petscan/src/33006f826342738833b06540cf9f97eb660ece40/trenderer.cpp?at=master&fileviewer=file-view-default#trenderer.cpp-74
This error handling was added because apparently you can't pass but so many pages to the PagePile API. However I'm beginning to believe I'm just using the API incorrectly, because at least one other user (T188603#4048032) said the API should support any number of pages. So I'm glad you created this bug. I will look into it more and let you know if I can fix it. Thanks
Well, they said 2000, so we'll have to keep some error handling.
Also: we're currently sometimes creating multiple piles with the same data, which is a shame. Probably could do some caching? As in remember what pile we created with what data and reuse that pile if it's the same data. Or, if it would cause memory issues, save a hash of the data and check afterwards if data is indeed the same. shouldn't take much longer.
On limits: the query mentioned that worked was ~50kb. The one failing here is 5.7kb. I am having trouble actually testing out the 50kb query. Given that this message was seven years ago, possibly the get limit was significantly lowered in the meantime.
If there's still demand for this fix, I'm happy to review a PR (or fix it myself when I have the time, which I can't say for sure when that will be). However I don't think it is that important nowadays as PagePile is (or was) slated to be replaced by Gulp. It looks like that effort has stalled, but T231891: Create a Generic List-building tool that can meet and exceed the applications of Pagepile is still open.