Maniphest T193490

formal parameter identifiers of Page.save() Page.put(), Page.put_async() shouldn't be different
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	May 1 2018, 12:22 PM

Description

There are some formal Parameter identifiers which differs:

save(summary=None, watch=None, minor=True, botflag=None, force=False, asynchronous=False, callback=None, apply_cosmetic_changes=None, quiet=False)

put(self, newtext, summary=u'', watchArticle=None, minorEdit=True, botflag=None, force=False, asynchronous=False, callback=None)

put_async(newtext, summary=u'', watchArticle=None, minorEdit=True, botflag=None, force=False, callback=None)

See T193467

Details

	Subject	Repo	Branch	Lines +/-
	[IMPR] Equalize parameters of Page.save, Page.put, Page.put_async	pywikibot/core	master	+19 -18

Customize query in gerrit

Related Objects

Mentioned Here: T193467: add_text produces "Unrecognized parameter: minorEdit" API warning

Event Timeline

Xqt created this task.May 1 2018, 12:22 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMay 1 2018, 12:22 PM

Xqt claimed this task.May 1 2018, 12:22 PM

Xqt triaged this task as Low priority.

Change 430062 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Equalize parameters of Page.save, Page.put, Page.put_async

https://gerrit.wikimedia.org/r/430062

gerritbot added a project: Patch-For-Review.May 1 2018, 12:47 PM

Xqt added subscribers: Dvorapa, matej_suchanek.May 1 2018, 12:52 PM

Framawiki subscribed.May 1 2018, 2:58 PM

Change 430062 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Equalize parameters of Page.save, Page.put, Page.put_async

https://gerrit.wikimedia.org/r/430062

Framawiki closed this task as Resolved.May 1 2018, 3:02 PM

• Vvjjkkii renamed this task from formal parameter identifiers of Page.save() Page.put(), Page.put_async() shouldn't be different to lwdaaaaaaa.Jul 1 2018, 1:12 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Xqt as the assignee of this task.

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from lwdaaaaaaa to formal parameter identifiers of Page.save() Page.put(), Page.put_async() shouldn't be different.Jul 2 2018, 7:13 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Xqt.

CommunityTechBot lowered the priority of this task from High to Low.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

matej_suchanek removed a project: Patch-For-Review.Jul 11 2018, 2:18 PM

matej_suchanek unsubscribed.

formal parameter identifiers of Page.save() Page.put(), Page.put_async() shouldn't be differentClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

formal parameter identifiers of Page.save() Page.put(), Page.put_async() shouldn't be different
Closed, ResolvedPublic
Actions