⚓ T194822 Multiple Explorer Dialogs

Subject	Repo	Branch	Lines +/-
Implement resizable, draggable and multiple Explorer Dialogs	wikidata/query/gui	master	+166 -44
Merging from 65b1430afa92a1745ede7df4168df5df3f8762c9:	wikidata/query/gui-deploy	production	+5 -5
Prevent opening of new Explorer Dialogs outside viewport	wikidata/query/gui	master	+2 -0
Merging from 74abb5ceb2d5eb866dcbed73447f116a7c537e36:	wikidata/query/gui-deploy	production	+59 -14

prssanna created this task.May 16 2018, 11:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2018, 11:17 AM

prssanna renamed this task from Multiple Explorer Dialogs(WIP) to Multiple Explorer Dialogs ( WIP ).May 16 2018, 11:23 AM

prssanna renamed this task from Multiple Explorer Dialogs ( WIP ) to [WIP]Multiple Explorer Dialogs.May 16 2018, 11:33 AM

prssanna added subscribers: • Jonas, Smalyshev, Lucas_Werkmeister_WMDE.

prssanna mentioned this in rWDQGb968379c4474: Multiple Explorer Dialogs.May 16 2018, 11:34 AM

• Jonas triaged this task as Low priority.May 16 2018, 12:17 PM

• Jonas moved this task from Backlog to Doing on the Wikidata Query UI board.

Is this what is happening now and you want to prevent it? Or what you want to enable? It'd be great to clarify this and the use case.

prssanna renamed this task from [WIP]Multiple Explorer Dialogs to [WIP] Multiple Explorer Dialogs.May 29 2018, 12:45 PM

prssanna updated the task description. (Show Details)

prssanna mentioned this in rWDQGadc15616c0e5: Implement resizable, draggable and multiple Explorer Dialogs.May 31 2018, 7:36 AM

Should I add an alert or a message that is displayed when a user tries to open a dialog that is already open?

prssanna mentioned this in rWDQGc13799b778db: Implement resizable, draggable and multiple Explorer Dialogs.Jun 1 2018, 1:39 PM

prssanna mentioned this in rWDQG39e409d25b2b: Implement resizable, draggable and multiple Explorer Dialogs.Jun 1 2018, 1:42 PM

prssanna mentioned this in rWDQGead0fdf81934: Implement resizable, draggable and multiple Explorer Dialogs.Jun 1 2018, 6:28 PM

Should I add an alert or a message that is displayed when a user tries to open a dialog that is already open?

Do you mean the one with the item ID same as one of the opened dialogs? I see two possibilities here:

Focus (bring to foreground, etc.) the dialog that has the same item ID
Just create a new one, regardless of what is already open

I am leaning towards the latter option - as one can change what is displayed in the dialogs, it may be legitimate case to open more than one and then do separate changes to them. I don't think we should prevent it.

Smalyshev renamed this task from [WIP] Multiple Explorer Dialogs to Multiple Explorer Dialogs.Jun 1 2018, 9:08 PM

prssanna mentioned this in rWDQG1ed702ab8fd4: Implement resizable, draggable and multiple Explorer Dialogs.Jun 2 2018, 5:27 PM

Yes the latter option does makes sense! I've changed the implementation to reflect that behaviour.

prssanna mentioned this in rWDQGbbf9d40c7d95: Implement resizable, draggable and multiple Explorer Dialogs.Jun 3 2018, 8:34 AM

prssanna mentioned this in rWDQG64d3e37ace45: Implement resizable, draggable and multiple Explorer Dialogs.Jun 3 2018, 3:42 PM

Change 433357 had a related patch set uploaded (by Prssanna; owner: Prssanna):
[wikidata/query/gui@master] Implement resizable, draggable and multiple Explorer Dialogs

https://gerrit.wikimedia.org/r/433357

gerritbot added a project: Patch-For-Review.Jun 4 2018, 7:14 PM

prssanna mentioned this in rWDQG74abb5ceb2d5: Implement resizable, draggable and multiple Explorer Dialogs.Jun 4 2018, 7:15 PM

Change 433357 merged by jenkins-bot:
[wikidata/query/gui@master] Implement resizable, draggable and multiple Explorer Dialogs

https://gerrit.wikimedia.org/r/433357

Change 437440 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 74abb5ceb2d5eb866dcbed73447f116a7c537e36:

https://gerrit.wikimedia.org/r/437440

• Jonas moved this task from Doing to Done on the Wikidata Query UI board.Jun 5 2018, 6:17 PM

Change 437440 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 74abb5ceb2d5eb866dcbed73447f116a7c537e36:

https://gerrit.wikimedia.org/r/437440

Change 437973 had a related patch set uploaded (by Prssanna; owner: Prssanna):
[wikidata/query/gui@master] Prevent opening of new Explorer Dialogs outside viewport

https://gerrit.wikimedia.org/r/437973

prssanna mentioned this in rWDQG65b1430afa92: Prevent opening of new Explorer Dialogs outside viewport.Jun 7 2018, 12:07 PM

Change 437973 merged by jenkins-bot:
[wikidata/query/gui@master] Prevent opening of new Explorer Dialogs outside viewport

https://gerrit.wikimedia.org/r/437973

Change 437980 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 65b1430afa92a1745ede7df4168df5df3f8762c9:

https://gerrit.wikimedia.org/r/437980

Change 437980 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 65b1430afa92a1745ede7df4168df5df3f8762c9:

https://gerrit.wikimedia.org/r/437980

• Vvjjkkii renamed this task from Multiple Explorer Dialogs to lvcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii removed prssanna as the assignee of this task.

• Vvjjkkii raised the priority of this task from Low to High.