Maniphest T195129

ActiveAbstract extension is missing @covers tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 20 2018, 1:51 AM

Description

PHPCS has identified that some of the ActiveAbstract PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

	Subject	Repo	Branch	Lines +/-
	Add @covers to unit tests	mediawiki/extensions/ActiveAbstract	master	+3 -1

Customize query in gerrit

Event Timeline

Legoktm added projects: ActiveAbstract, Test-Coverage.May 20 2018, 1:51 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:51 AM

• Vvjjkkii renamed this task from ActiveAbstract extension is missing @covers tags to 2mcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 2mcaaaaaaa to ActiveAbstract extension is missing @covers tags.Jul 1 2018, 5:28 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 455125 had a related patch set uploaded (by Legoktm; owner: Umherirrender):
[mediawiki/extensions/ActiveAbstract@master] Add @covers to unit tests

https://gerrit.wikimedia.org/r/455125

gerritbot added a project: Patch-For-Review.Aug 25 2018, 6:13 AM

Change 455125 merged by jenkins-bot:
[mediawiki/extensions/ActiveAbstract@master] Add @covers to unit tests

https://gerrit.wikimedia.org/r/455125

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 1 2018, 8:00 AM

Umherirrender closed this task as Resolved.Sep 1 2018, 8:09 AM

Umherirrender claimed this task.

Umherirrender triaged this task as High priority.