Page MenuHomePhabricator
Create Task
Maniphest T195166

TwnMainPage extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the TwnMainPage PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

If you are not already familiar with PHPUnit tests and would like to learn more about this: https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests has links to some good material on the basics of testing.

Mentors: @Legoktm

Details

SubjectRepoBranchLines +/-
CachedStatTests.php: Add @covers tagmediawiki/extensions/TwnMainPagemaster+1 -1
Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-TwnMainPage, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
• Vvjjkkii renamed this task from TwnMainPage extension is missing @covers tags to 1lcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 1lcaaaaaaa to TwnMainPage extension is missing @covers tags.Jul 1 2018, 5:02 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Legoktm added a project: Google-Code-in-2018.Sep 12 2018, 5:09 AM
Legoktm updated the task description. (Show Details)
Aklapper updated the task description. (Show Details)Oct 7 2018, 1:03 AM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

https://codein.withgoogle.com/tasks/4954384740909056/

gerritbot subscribed.Nov 11 2018, 2:09 AM

Change 472863 had a related patch set uploaded (by Rafidaslam; owner: Rafid Aslam):
[mediawiki/extensions/TwnMainPage@master] CachedStatTests.php: Add @covers tag

https://gerrit.wikimedia.org/r/472863

gerritbot added a project: Patch-For-Review.Nov 11 2018, 2:09 AM
gerritbot added a comment.Dec 10 2018, 3:14 PM

Change 472863 merged by jenkins-bot:
[mediawiki/extensions/TwnMainPage@master] CachedStatTests.php: Add @covers tag

https://gerrit.wikimedia.org/r/472863

Umherirrender closed this task as Resolved.Apr 21 2019, 11:26 AM
Umherirrender assigned this task to rafidaslam.
Umherirrender triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL