Page MenuHomePhabricator
Create Task
Maniphest T195170

timeline extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the timeline PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

SubjectRepoBranchLines +/-
Add @covers to unit testmediawiki/extensions/timelinemaster+1 -1
Customize query in gerrit

Event Timeline

Legoktm added projects: Reading Epics (Timeline), Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
Legoktm edited projects, added EasyTimeline; removed Reading Epics (Timeline).May 20 2018, 1:55 AM
• Vvjjkkii renamed this task from timeline extension is missing @covers tags to xlcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from xlcaaaaaaa to timeline extension is missing @covers tags.Jul 1 2018, 4:58 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Aug 25 2018, 6:03 AM

Change 455122 had a related patch set uploaded (by Legoktm; owner: Umherirrender):
[mediawiki/extensions/timeline@master] Add @covers to unit test

https://gerrit.wikimedia.org/r/455122

gerritbot added a project: Patch-For-Review.Aug 25 2018, 6:03 AM
gerritbot added a comment.Aug 25 2018, 6:21 AM

Change 455122 merged by jenkins-bot:
[mediawiki/extensions/timeline@master] Add @covers to unit test

https://gerrit.wikimedia.org/r/455122

Legoktm closed this task as Resolved.Aug 25 2018, 6:22 AM
Legoktm assigned this task to Umherirrender.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 25 2018, 7:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL