Maniphest T195227

Template serialization can dirty diff transclusions with 'constructor' as a template arg
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	May 21 2018, 2:48 AM

Description

This from eswiki:

{{Ficha de obra de arte
|nombre        = Mosaico de Issos
|imagen        = Alexander (Battle of Issus) Mosaic.jpg
|tamaño imagen = 300px
|pie imagen    = El mosaico completo
|autor         = [[Filoxeno de Eretria]]
|diseñador     = 
|constructor   = 
|fecha         = {{esd|c. 325 a. C.}}
|localización  = [[Museo Arqueológico Nacional de Nápoles]]
|estilo        = 
|material      = 
|técnica       = [[Mosaico]]
|dimensiones   = {{esd|272 cm × 513 cm}}
|peso          = 
}}

This roundtrips in wt2wt as:

{{Ficha de obra de arte
|nombre        = Mosaico de Issos
|imagen        = Alexander (Battle of Issus) Mosaic.jpg
|tamaño imagen = 300px
|pie imagen    = El mosaico completo
|autor         = [[Filoxeno de Eretria]]
|diseñador     = 
|fecha         = {{esd|c. 325 a. C.}}
|localización  = [[Museo Arqueológico Nacional de Nápoles]]
|estilo        = 
|material      = 
|técnica       = [[Mosaico]]
|dimensiones   = {{esd|272 cm × 513 cm}}
|peso          = 
|constructor=}}

Where the "constructor" has shifted positions to become the last arg.

Details

	Subject	Repo	Branch	Lines +/-
	Check for own properties when using object as a dict	mediawiki/services/parsoid	master	+12 -1

Customize query in gerrit

Related Objects

Mentioned Here: T65370: Use Maps and Sets in WikiConfig

Event Timeline

ssastry created this task.May 21 2018, 2:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2018, 2:48 AM

ssastry triaged this task as Medium priority.May 21 2018, 2:48 AM

ssastry moved this task from Needs Triage to html2wt on the Parsoid board.May 22 2018, 2:51 PM

zhwiki/天花湖水庫 as well

Arlolra updated the task description. (Show Details)May 22 2018, 5:19 PM

Arlolra claimed this task.May 23 2018, 10:03 PM

Linking to T65370

Change 434995 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Check for own properties when using object as a dict

https://gerrit.wikimedia.org/r/434995

gerritbot added a project: Patch-For-Review.May 24 2018, 7:32 PM

Change 434995 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Check for own properties when using object as a dict

https://gerrit.wikimedia.org/r/434995

Arlolra closed this task as Resolved.May 24 2018, 9:53 PM

• Vvjjkkii renamed this task from Template serialization can dirty diff transclusions with 'constructor' as a template arg to ckcaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Arlolra as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

• Community_Tech_bot renamed this task from ckcaaaaaaa to Template serialization can dirty diff transclusions with 'constructor' as a template arg.Jul 1 2018, 6:20 AM

• Community_Tech_bot closed this task as Resolved.

• Community_Tech_bot assigned this task to Arlolra.

• Community_Tech_bot updated the task description. (Show Details)

• Community_Tech_bot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

• Community_Tech_bot added subscribers: gerritbot, Aklapper.

CommunityTechBot lowered the priority of this task from High to Medium.Jul 3 2018, 3:26 AM

Template serialization can dirty diff transclusions with 'constructor' as a template argClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Template serialization can dirty diff transclusions with 'constructor' as a template arg
Closed, ResolvedPublic
Actions