Page MenuHomePhabricator
Create Task
Maniphest T195337

Update Ingenico WX audit parser to handle txns from new API
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We need to mark the new ones as gateway=ingenico

We also need to switch to using the JSON blobs in the 'redirect' log messages for data. Bonus: we'll get the right utm_ fields that way too.

Details

SubjectRepoBranchLines +/-
Robust-ify needsTokenizing logicwikimedia/fundraising/SmashPigmaster+12 -2
Ingenico audit: deal with untokenized recurring.wikimedia/fundraising/crmmaster+32 -7
Move queue sending fns out of global scopewikimedia/fundraising/crmmaster+56 -92
Ingenico audit handles both APIswikimedia/fundraising/crmmaster+113 -27
Audit: allow log_filename functions to return arrayswikimedia/fundraising/crmmaster+106 -98
Audit functions can deal with multiple logs for one datewikimedia/fundraising/crmmaster+27 -17
Fix IDs for Ingenico audit entrieswikimedia/fundraising/SmashPigmaster+75 -26
Indicate correct gateway for Connect API donationswikimedia/fundraising/SmashPigmaster+46 -7
Ingenico audit: use JSON blob instead of XMLwikimedia/fundraising/crmmaster+19 -147
Audit: get more fields from JSON logswikimedia/fundraising/crmmaster+36 -60
Customize query in gerrit

Event Timeline

Ejegg created this task.May 23 2018, 1:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2018, 1:27 AM
Ejegg renamed this task from Update Ingenico WX audit parser to differentiate txns from new API to Update Ingenico WX audit parser to handle txns from new API.May 24 2018, 2:58 PM
Ejegg triaged this task as Medium priority.
Ejegg updated the task description. (Show Details)
Ejegg set the point value for this task to 2.
gerritbot subscribed.May 24 2018, 2:58 PM

Change 434928 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Audit: get more fields from JSON logs

https://gerrit.wikimedia.org/r/434928

gerritbot added a project: Patch-For-Review.May 24 2018, 2:58 PM
gerritbot added a comment.May 24 2018, 4:01 PM

Change 434945 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Ingenico audit: use JSON blob instead of XML

https://gerrit.wikimedia.org/r/434945

gerritbot added a comment.May 24 2018, 6:07 PM

Change 434928 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Audit: get more fields from JSON logs

https://gerrit.wikimedia.org/r/434928

gerritbot added a comment.May 24 2018, 6:34 PM

Change 434945 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Ingenico audit: use JSON blob instead of XML

https://gerrit.wikimedia.org/r/434945

gerritbot added a comment.May 24 2018, 11:09 PM

Change 435066 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Indicate correct gateway for Connect API donations

https://gerrit.wikimedia.org/r/435066

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Karma chameleons hide amongst us board.May 25 2018, 3:28 PM
gerritbot added a comment.May 25 2018, 7:49 PM

Change 435066 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Indicate correct gateway for Connect API donations

https://gerrit.wikimedia.org/r/435066

gerritbot added a comment.May 25 2018, 8:08 PM

Change 435220 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP: Audit functions can deal with multiple logs for one date

https://gerrit.wikimedia.org/r/435220

gerritbot added a comment.May 25 2018, 9:06 PM

Change 435286 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Audit: allow log_filename functions to return arrays

https://gerrit.wikimedia.org/r/435286

gerritbot added a comment.May 25 2018, 10:37 PM

Change 435293 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP Ingenico audit handles both APIs

https://gerrit.wikimedia.org/r/435293

gerritbot added a comment.May 25 2018, 10:52 PM

Change 435294 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] WIP: Fix IDs for Ingenico audit entries

https://gerrit.wikimedia.org/r/435294

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.May 29 2018, 7:20 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Karma chameleons hide amongst us board.May 29 2018, 7:22 PM
gerritbot added a comment.Jun 4 2018, 4:19 PM

Change 435294 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Fix IDs for Ingenico audit entries

https://gerrit.wikimedia.org/r/435294

• DStrine added a project: Fundraising Sprint Lactose is unusually tolerant.Jun 5 2018, 8:34 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Lactose is unusually tolerant board.Jun 6 2018, 5:04 PM
gerritbot added a comment.Jun 12 2018, 10:09 PM

Change 435220 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Audit functions can deal with multiple logs for one date

https://gerrit.wikimedia.org/r/435220

gerritbot added a comment.Jun 12 2018, 10:15 PM

Change 435286 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Audit: allow log_filename functions to return arrays

https://gerrit.wikimedia.org/r/435286

gerritbot added a comment.Jun 12 2018, 10:16 PM

Change 435293 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Ingenico audit handles both APIs

https://gerrit.wikimedia.org/r/435293

• DStrine added a project: Fundraising Sprint Matt Damon to head up Space Force.Jun 18 2018, 8:21 PM
• Vvjjkkii renamed this task from Update Ingenico WX audit parser to handle txns from new API to ahcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii removed Ejegg as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from ahcaaaaaaa to Update Ingenico WX audit parser to handle txns from new API.Jul 2 2018, 4:41 AM
CommunityTechBot assigned this task to Ejegg.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 2.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Matt Damon to head up Space Force board.Jul 3 2018, 3:41 PM
• DStrine added a project: Fundraising Sprint Naming Sprints Is Not Important.Jul 11 2018, 9:26 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Naming Sprints Is Not Important board.Jul 11 2018, 10:28 PM
Ejegg added a comment.Jul 18 2018, 5:32 PM

Still TODO: handle first-time recurring donations. This will use https://gerrit.wikimedia.org/r/441251

Ejegg added a comment.Jul 18 2018, 5:32 PM
This comment was removed by Ejegg.
Ejegg moved this task from Review to Doing on the Fundraising Sprint Naming Sprints Is Not Important board.Jul 18 2018, 5:33 PM
• DStrine added a project: Fundraising Sprint Owls.Jul 24 2018, 8:14 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Owls board.Jul 27 2018, 10:18 PM
gerritbot added a comment.Jul 27 2018, 10:38 PM

Change 448808 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Move queue sending fns out of global scope

https://gerrit.wikimedia.org/r/448808

gerritbot added a comment.Jul 27 2018, 11:29 PM

Change 448820 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Ingenico audit: deal with untokenized recurring.

https://gerrit.wikimedia.org/r/448820

gerritbot added a comment.Jul 28 2018, 12:00 AM

Change 448832 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Robust-ify needsTokenizing logic

https://gerrit.wikimedia.org/r/448832

Ejegg moved this task from Doing to Review on the Fundraising Sprint Owls board.Jul 30 2018, 8:18 PM
gerritbot added a comment.Aug 2 2018, 10:19 PM

Change 448808 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Move queue sending fns out of global scope

https://gerrit.wikimedia.org/r/448808

gerritbot added a comment.Aug 2 2018, 10:22 PM

Change 448820 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Ingenico audit: deal with untokenized recurring.

https://gerrit.wikimedia.org/r/448820

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Owls board.Aug 3 2018, 2:44 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Owls board.Aug 6 2018, 11:50 PM
Ejegg closed this task as Resolved.Aug 7 2018, 8:14 PM
gerritbot added a comment.Feb 7 2024, 4:14 PM

Change 448832 abandoned by Ejegg:

[wikimedia/fundraising/SmashPig@master] Robust-ify needsTokenizing logic

Reason:

jettisoning ingenico

https://gerrit.wikimedia.org/r/448832

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2024, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits