Page MenuHomePhabricator
Create Task
Maniphest T195395

ImageMetrics: LoadingTimeLogger gets called when no image is present (failing test)
Closed, DuplicatePublic
Actions

Description

The QUnit test suite is failing on current master. Most likely something asynchronous that was previously passing due to race conditions (e.g. maybe the assertion was done too soon before it was fully processed).

The upgrade to QUnit 2 revealed the issue.

I've disabled this assertion with FIXME in https://gerrit.wikimedia.org/r/#/c/433122/

Event Timeline

Krinkle created this task.May 23 2018, 6:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2018, 6:27 PM
• Vvjjkkii renamed this task from ImageMetrics: LoadingTimeLogger gets called when no image is present (failing test) to ofcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from ofcaaaaaaa to ImageMetrics: LoadingTimeLogger gets called when no image is present (failing test).Jul 2 2018, 3:55 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Kizule closed this task as a duplicate of T206290: ImageMetrics qunit test mw.imageMetrics.LoadingTimeLogger is failing.Dec 14 2019, 3:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL