Page MenuHomePhabricator

"Modernizr is not defined" JS error
Closed, ResolvedPublic

Description

Caused by https://gerrit.wikimedia.org/r/#/c/336047/. There's still one line (line 24) in resources/js/gamepress.js which references Modernizr. The whole large chunk of code can presumably simply be deleted, assuming we're not bothering to support ancient browsers.

Event Timeline

ashley created this task.May 26 2018, 12:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2018, 12:38 PM
ashley triaged this task as High priority.May 26 2018, 12:38 PM

Change 435632 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Gamepress@master] Remove leftover Modernizr fallback for CSS transitions

https://gerrit.wikimedia.org/r/435632

Change 435632 merged by jenkins-bot:
[mediawiki/skins/Gamepress@master] Remove leftover Modernizr fallback for CSS transitions

https://gerrit.wikimedia.org/r/435632

SamanthaNguyen closed this task as Resolved.May 26 2018, 2:57 PM
SamanthaNguyen removed a project: Patch-For-Review.
SamanthaNguyen moved this task from Backlog to Bugs on the Gamepress board.
SamanthaNguyen edited subscribers, added: SamanthaNguyen; removed: gerritbot.
Vvjjkkii renamed this task from "Modernizr is not defined" JS error to k8baaaaaaa.Jul 1 2018, 1:08 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed SamanthaNguyen as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Yann renamed this task from k8baaaaaaa to "Modernizr is not defined" JS error.Jul 1 2018, 1:52 PM
Yann closed this task as Resolved.
Yann assigned this task to SamanthaNguyen.
Yann updated the task description. (Show Details)
Yann added a subscriber: Aklapper.