Page MenuHomePhabricator
Create Task
Maniphest T195887

LanguageVariantNode's not rendering correctly
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

image.png (94×394 px, 10 KB)

Details

SubjectRepoBranchLines +/-
Update language variant node to use new invisible icon APImediawiki/extensions/VisualEditormaster+25 -81
Update VE core submodule to master (aca98533e)mediawiki/extensions/VisualEditormaster+1 -1
Upstream comment node's invisble icon with label into focusable nodeVisualEditor/VisualEditormaster+62 -92
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.May 29 2018, 4:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 4:24 PM
gerritbot subscribed.May 29 2018, 4:25 PM

Change 436058 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Upstream comment node's invisble icon with label into focusable node

https://gerrit.wikimedia.org/r/436058

gerritbot added a project: Patch-For-Review.May 29 2018, 4:25 PM
gerritbot added a comment.May 29 2018, 5:01 PM

Change 436062 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update language variant node to new use invisible icon API

https://gerrit.wikimedia.org/r/436062

• Deskana triaged this task as Medium priority.May 29 2018, 6:32 PM
• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.
• Deskana moved this task from Incoming to Code review on the VisualEditor (Current work) board.
Jdforrester-WMF assigned this task to Esanders.Jun 1 2018, 9:39 PM
gerritbot added a comment.Jun 4 2018, 3:43 PM

Change 436058 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Upstream comment node's invisble icon with label into focusable node

https://gerrit.wikimedia.org/r/436058

gerritbot added a comment.Jun 4 2018, 4:46 PM

Change 437288 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aca98533e)

https://gerrit.wikimedia.org/r/437288

gerritbot added a comment.Jun 4 2018, 5:01 PM

Change 437288 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aca98533e)

https://gerrit.wikimedia.org/r/437288

Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor-ContentLanguage.Jun 4 2018, 5:36 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 6:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Jun 4 2018, 6:19 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jun 4 2018, 6:42 PM

Change 436062 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update language variant node to use new invisible icon API

https://gerrit.wikimedia.org/r/436062

• Deskana closed this task as Resolved.Jun 5 2018, 4:47 PM
Jdforrester-WMF set the point value for this task to 1.Jun 13 2018, 6:25 PM
• Vvjjkkii renamed this task from LanguageVariantNode's not rendering correctly to 01baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 01baaaaaaa to LanguageVariantNode's not rendering correctly.Jul 2 2018, 2:50 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Esanders.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 1.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL