Page MenuHomePhabricator

Use normalised log message for "Loading global options"
Closed, ResolvedPublic

Description

The current logging performs the string substitution directly in the code, which means the messages cannot be grouped, counted, or easily excluded from a larger result set in Logstash.

For example:

It is common to use PSR-3/Monolog "context" for these, so that the normalised_message (the original string passed to info()) is the same across all messages, while still having the same message output as before. See an example.

Details

Related Gerrit Patches:
mediawiki/extensions/GlobalPreferences : masterParameterize debug log entry

Event Timeline

Krinkle created this task.Jun 3 2018, 2:26 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptJun 3 2018, 2:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 437148 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GlobalPreferences@master] Parameterize debug log entry

https://gerrit.wikimedia.org/r/437148

Change 437148 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Parameterize debug log entry

https://gerrit.wikimedia.org/r/437148

Legoktm closed this task as Resolved.Jun 4 2018, 3:20 AM
Legoktm claimed this task.