Maniphest T196346

[GoogleAppEngine] exception when saving page
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	hashar
	Jun 4 2018, 10:33 AM

Description

When saving a page:

action=submit
TypeError from line 60 of extensions/GoogleAppEngine/job/JobQueueGAE.php:
Argument 1 passed to JobQueueGAE::convertJobToTask() must be an instance of Job, instance of JobSpecification given,
called in extensions/GoogleAppEngine/job/JobQueueGAE.php on line 36

Reproducible by installing the extension then trying to save a page. Or with Quibble : ZUUL_PROJECT=mediawiki/extensions/GoogleAppEngine quibble --run=selenium.

should-be-creatable.png (894×1 px, 139 KB)

Fixed by https://gerrit.wikimedia.org/r/437259

Then a page fails to load with Call to undefined function google\net\bccomp() ( https://github.com/GoogleCloudPlatform/appengine-php-sdk/issues/15 ) which is due to the Quibble image lacking the PHP bcmath extension.

Fixed by adding bcmath https://gerrit.wikimedia.org/r/442338

Details

Subject	Repo	Branch	Lines +/-
Job -> IJobSpecification	mediawiki/extensions/GoogleAppEngine	master	+1 -1
Migrate GoogleAppEngine to Quibble without Selenium	integration/config	master	+1 -2
Bump php7/hhvm Quibble jobs to 0.0.19-1	integration/config	master	+2 -2
docker: add bcmath/ldap to Quibble images	integration/config	master	+16 -0
GoogleAppEngine requires composer	integration/config	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T199047: Add "gmp" php extension to Quibble images
T198336: OpenStackManager tests fail on Quibble container: Error: Call to undefined function ldap_bind()
T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker
Mentioned Here: T198336: OpenStackManager tests fail on Quibble container: Error: Call to undefined function ldap_bind()

Event Timeline

hashar created this task.Jun 4 2018, 10:33 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2018, 10:33 AM

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 4 2018, 10:34 AM

Change 437259 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/GoogleAppEngine@master] Job -> iJobSpecification

https://gerrit.wikimedia.org/r/437259

gerritbot added a project: Patch-For-Review.Jun 4 2018, 2:25 PM

Change 442294 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] GoogleAppEngine requires composer

https://gerrit.wikimedia.org/r/442294

Change 442294 merged by jenkins-bot:
[integration/config@master] GoogleAppEngine requires composer

https://gerrit.wikimedia.org/r/442294

hashar updated the task description. (Show Details)Jun 27 2018, 4:04 PM

Change 442338 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: add bcmath/ldap to Quibble images

https://gerrit.wikimedia.org/r/442338

Change 442338 merged by jenkins-bot:
[integration/config@master] docker: add bcmath/ldap to Quibble images

https://gerrit.wikimedia.org/r/442338

Change 442339 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Bump php7/hhvm Quibble jobs to 0.0.19-1

https://gerrit.wikimedia.org/r/442339

Mentioned in SAL (#wikimedia-releng) [2018-06-27T16:27:14Z] <hashar> Building Docker containers releng/quibble-jessie-php55:0.0.19-1 and releng/quibble-stretch:0.0.19-1 | T196346 T198336

Stashbot mentioned this in T198336: OpenStackManager tests fail on Quibble container: Error: Call to undefined function ldap_bind().Jun 27 2018, 4:27 PM

hashar claimed this task.Jun 27 2018, 4:27 PM

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 27 2018, 4:27 PM

• Vvjjkkii renamed this task from [GoogleAppEngine] exception when saving page to 9obaaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii removed hashar as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from 9obaaaaaaa to [GoogleAppEngine] exception when saving page.Jul 1 2018, 10:45 PM

CommunityTechBot assigned this task to hashar.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Change 442339 merged by jenkins-bot:
[integration/config@master] Bump php7/hhvm Quibble jobs to 0.0.19-1

https://gerrit.wikimedia.org/r/442339

hashar updated the task description. (Show Details)Jul 2 2018, 9:29 AM

Change 444418 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate GoogleAppEngine to Quibble without Selenium

https://gerrit.wikimedia.org/r/444418