Maniphest T196510

[SocialLogin] $wgSocialLoginServices has no default triggering notice/warning
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Jun 5 2018, 8:25 PM

Description

With SocialLogin extension, when running install.php --with-extensions:

PHP Notice:  Undefined variable: wgSocialLoginServices in extensions/SocialLogin/SocialLogin.php on line 16
PHP Warning:  Invalid argument supplied for foreach() in extensions/SocialLogin/SocialLogin.php on line 16

Details

	Subject	Repo	Branch	Lines +/-
	Ensure wgSocialLoginServices has a sane default	mediawiki/extensions/SocialLogin	REL1_31	+5 -0
	Ensure wgSocialLoginServices has a sane default	mediawiki/extensions/SocialLogin	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker

Event Timeline

hashar created this task.Jun 5 2018, 8:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2018, 8:25 PM

Change 437616 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/SocialLogin@master] Ensure wgSocialLoginServices has a sane default

https://gerrit.wikimedia.org/r/437616

gerritbot added a project: Patch-For-Review.Jun 5 2018, 8:31 PM

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 5 2018, 8:32 PM

hashar closed this task as Resolved.Jun 5 2018, 8:46 PM

hashar claimed this task.

Change 437616 merged by jenkins-bot:
[mediawiki/extensions/SocialLogin@master] Ensure wgSocialLoginServices has a sane default

https://gerrit.wikimedia.org/r/437616

• Vvjjkkii renamed this task from [SocialLogin] $wgSocialLoginServices has no default triggering notice/warning to pkbaaaaaaa.Jul 1 2018, 1:05 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed hashar as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot assigned this task to hashar.Jul 1 2018, 8:11 PM

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJul 1 2018, 8:11 PM

CommunityTechBot renamed this task from pkbaaaaaaa to [SocialLogin] $wgSocialLoginServices has no default triggering notice/warning.Jul 1 2018, 8:11 PM

CommunityTechBot closed this task as Resolved.

CommunityTechBot raised the priority of this task from High to Needs Triage.

Peachey88 edited projects, added MediaWiki-extensions-SocialLogin; removed MediaWiki-extensions-Other.Feb 24 2020, 9:48 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2020, 10:10 AM

Change 653482 had a related patch set uploaded (by Legoktm; owner: Hashar):
[mediawiki/extensions/SocialLogin@REL1_31] Ensure wgSocialLoginServices has a sane default

https://gerrit.wikimedia.org/r/653482

gerritbot added a project: Patch-For-Review.Jan 3 2021, 1:35 AM

Change 653482 merged by jenkins-bot:
[mediawiki/extensions/SocialLogin@REL1_31] Ensure wgSocialLoginServices has a sane default