Page MenuHomePhabricator
Create Task
Maniphest T196609

Split wikidata dispatch-script metrics by wiki
Closed, ResolvedPublic
Actions

Description

Discovered while investigating T194602

Metrics reported on https://grafana.wikimedia.org/dashboard/db/wikidata-dispatch-script are currently broadly grouped for all wikibases.
This should be split per wiki / dbname as currently the testwikidata runs of the script are contaminating the wikidatawiki data making it harder to investigate.

This will require including the dbname in the metric name when reported in the PHP statsd calls in the dispatch script and other classes.

Details

SubjectRepoBranchLines +/-
Fix PerDbnameStatsdDataFactory metric prefixmediawiki/coremaster+1 -1
Use getPerDbNameStatsdDataFactory for dispatch metricsmediawiki/extensions/Wikibasemaster+3 -3
Add MediaWikiService::getPerDbNameStatsdDataFactorymediawiki/coremaster+18 -0
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Jun 7 2018, 8:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2018, 8:10 AM
Addshore added a project: Wikidata-Campsite.Jun 7 2018, 8:10 AM
Addshore updated the task description. (Show Details)Jun 26 2018, 10:07 AM
• Vvjjkkii renamed this task from Split wikidata dispatch-script metrics by wiki to yhbaaaaaaa.Jul 1 2018, 1:05 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from yhbaaaaaaa to Split wikidata dispatch-script metrics by wiki.Jul 2 2018, 3:12 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Jul 2 2018, 5:02 PM

Change 443467 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Add MediaWikiService::getPerDbNameStatsdDataFactory

https://gerrit.wikimedia.org/r/443467

gerritbot added a project: Patch-For-Review.Jul 2 2018, 5:02 PM
gerritbot added a comment.Jul 2 2018, 5:08 PM

Change 443469 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Use getPerDbNameStatsdDataFactory for dispatch metrics

https://gerrit.wikimedia.org/r/443469

Addshore added a comment.Jul 2 2018, 5:08 PM

Once both patches are merged and deployed the dashboards on grafana will need to be updated

Addshore claimed this task.Jul 2 2018, 5:08 PM
Addshore moved this task from Incoming to Peer Review on the Wikidata-Campsite board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptJul 2 2018, 5:08 PM
gerritbot added a comment.Jul 3 2018, 7:58 AM

Change 443467 merged by jenkins-bot:
[mediawiki/core@master] Add MediaWikiService::getPerDbNameStatsdDataFactory

https://gerrit.wikimedia.org/r/443467

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 3 2018, 8:00 AM
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Jul 3 2018, 12:04 PM
• Jonas closed this task as Resolved.Jul 3 2018, 12:44 PM
• Jonas moved this task from Peer Review to Done on the Wikidata-Campsite board.
gerritbot added a comment.Jul 3 2018, 1:01 PM

Change 443469 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use getPerDbNameStatsdDataFactory for dispatch metrics

https://gerrit.wikimedia.org/r/443469

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Jul 11 2018, 1:13 PM
Addshore mentioned this in T200420: Wikidata dispatching stuck (not releasing lockmanager locks).Jul 26 2018, 12:09 PM
gerritbot added a comment.Jul 26 2018, 12:24 PM

Change 448031 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Fix PerDbnameStatsdDataFactory metric prefix

https://gerrit.wikimedia.org/r/448031

Addshore mentioned this in T200424: https://grafana.wikimedia.org/dashboard/db/wikidata-dispatch-script not showing data.Jul 26 2018, 12:32 PM
gerritbot added a comment.Jul 31 2018, 9:50 AM

Change 448031 merged by jenkins-bot:
[mediawiki/core@master] Fix PerDbnameStatsdDataFactory metric prefix

https://gerrit.wikimedia.org/r/448031

Addshore mentioned this in T208750: Requesting access to graphite hosts for addshore.Nov 5 2018, 5:30 PM
colewhite mentioned this in T359436: StatsLib equivalent of PerDbNameStatsdDataFactory.Mar 6 2024, 7:11 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 6 2024, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits