Page MenuHomePhabricator
Create Task
Maniphest T197195

Combine input and button on portal into one visual element
Closed, ResolvedPublic
Actions

Description

Follow-up to T195973:

image.png (676×996 px, 192 KB)

Should follow ActionFieldLayout treatment.

Details

SubjectRepoBranchLines +/-
Combine input and search button on intriniscally tied together widgetwikimedia/portalsmaster+18 -20
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Jun 13 2018, 11:01 PM
Restricted Application added projects: Discovery-ARCHIVED, UI-Standardization. · View Herald TranscriptJun 13 2018, 11:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Vvjjkkii renamed this task from Combine input and button on portal into one visual element to o1aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from o1aaaaaaaa to Combine input and button on portal into one visual element.Jul 2 2018, 7:12 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Jdrewniak moved this task from Untriaged to Design on the Wikimedia-Portals board.Aug 31 2018, 2:43 PM
gerritbot subscribed.Nov 27 2018, 4:32 AM

Change 460185 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wikimedia/portals@master] Combine input and search button on intriniscally tied together widget

https://gerrit.wikimedia.org/r/460185

gerritbot added a project: Patch-For-Review.Nov 27 2018, 4:32 AM
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Nov 27 2018, 4:33 AM
gerritbot added a comment.Nov 29 2018, 4:32 PM

Change 460185 merged by jenkins-bot:
[wikimedia/portals@master] Combine input and search button on intriniscally tied together widget

https://gerrit.wikimedia.org/r/460185

Volker_E assigned this task to Ryasmeen.EditedNov 29 2018, 5:52 PM
Volker_E added a subscriber: Ryasmeen.

This is going live on Monday 3rd.
@Ryasmeen Would you verify it on desktop/mobile?

There should be no visual gap between input and search button anymore and no visual regressions aside of it, for example in the autocomplete dropdown…

Ryasmeen added a comment.Nov 29 2018, 11:01 PM

@Volker_E: Sure, where do you want me to check this?

Volker_E added a comment.Nov 30 2018, 2:04 AM

@Ryasmeen Ah, sorry. When I talk about portals, I mostly refer to https://www.wikipedia.org/

Volker_E closed this task as Resolved.Jan 23 2019, 8:40 PM
Volker_E claimed this task.

Has been resolved a while ago. Rollout successful.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 23 2019, 8:40 PM
Volker_E removed a project: Patch-For-Review.Jan 23 2019, 8:41 PM
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
Volker_E added a subscriber: • Debbieashforth.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits