Page MenuHomePhabricator

Improve look of constraint reports in Timeless skin
Open, LowestPublic

Description

Constraint reports generally look okay under Timeless, but there are two issues in this screenshot:

Screenshot-2018-6-14 Douglas Adams(1).png (292×642 px, 21 KB)

For comparison, under Vector:

Screenshot-2018-6-14 Douglas Adams.png (235×604 px, 17 KB)

  • Timeless grants a generous margin-top to headings. That should be easy enough to override. Alternatively, we could also stop making the constraint name a heading (h4), which would also get rid of the serif font. I’m not sure which I would prefer.
  • The “help” and “discuss” links flow into the violation message – in Vector, they also don’t fit into one line with the constraint type name, but they’re still separated from the violation message. I haven’t yet figured out what part of CSS effects this change.

Event Timeline

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Vvjjkkii renamed this task from Improve look of constraint reports in Timeless skin to 6zaaaaaaaa.Jul 1 2018, 1:03 AM
Vvjjkkii raised the priority of this task from Lowest to High.
Vvjjkkii updated the task description. (Show Details)
CommunityTechBot renamed this task from 6zaaaaaaaa to Improve look of constraint reports in Timeless skin.Jul 2 2018, 12:12 PM
CommunityTechBot lowered the priority of this task from High to Lowest.
CommunityTechBot updated the task description. (Show Details)