Page MenuHomePhabricator
Create Task
Maniphest T19822

AbuseFilter warning page should display original page text
Open, LowPublic
Actions

Description

Author: skizzerz

Description:
Currently in AbuseFilter, doing an action that triggers a warning keeps one on the edit page, but their version that they tried to save is shown in the edit box. Requesting that an interface like edit conflicts be used so that they may re-modify the original text if they so wish without needing to refresh the page (have a notice saying the original text is on top, their changed text on the bottom, and only the top will take effect when saved -- basically the same interface used for an edit conflict, just with the AbuseFilter warning prepended to it).

Details

Reference
bz17822

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:35 PM
• bzimport added a project: AbuseFilter.
• bzimport set Reference to bz17822.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 6 2009, 11:38 PM
• bzimport added a comment.Mar 10 2009, 9:43 AM

MacGyverMagic wrote:

*** Bug 17903 has been marked as a duplicate of this bug. ***

• werdna added a comment.Mar 12 2009, 11:42 AM

Might be more sensible to make the change in core so it happens with SpamBlacklist et al too.

• werdna added a comment.Jul 16 2009, 4:47 PM

Marking this bug as Lowest priority.

I've done this in a batch to (usually enhancement request) bugs where:

  • It is not clear that this bug should be fixed.
  • It is not clear how to fix this bug.
  • There are difficulties or complications in fixing this bug, which are not justified by the importance of the bug.
  • This is an extremely minor bug that could not be fixed in a few lines of code.

If you're interested in having one of these bugs fixed, your best bet is to write the patch yourself.

waldyrious added a comment.Oct 21 2009, 9:19 AM

(In reply to comment #2)

Might be more sensible to make the change in core so it happens with
SpamBlacklist et al too.

FYI, that's requested on bug 9416.

• werdna unsubscribed.Dec 10 2014, 6:16 PM
Daimona updated the task description. (Show Details)Dec 24 2018, 1:46 PM
Daimona removed a subscriber: • wikibugs-l-list.
Daimona subscribed.Dec 24 2018, 1:48 PM

This is a change to be made in core. AbuseFilter simply does its work and reports errors to the EditPage code using the EditFilterMergedContent hook, but displaying the warning is handled there.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL