Page MenuHomePhabricator

For RevisionDelete: Unsuppression is logged in the deletion log, not the suppression log
Closed, DeclinedPublic

Description

Author: mcdevitd

Description:
When I undo suppression of a revision, the action gets logged in the deletion log, even though the original suppression gets logged in the suppression log. This creates misleading results when using [[Special:Log/suppress]], since it's impossible to tell that something was unsuppressed from the log without checking the page's deletion log as well.


Version: unspecified
Severity: normal

Details

Reference
bz17854

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:31 PM
bzimport set Reference to bz17854.
bzimport added a subscriber: Unknown Object (MLST).

mike.lifeguard+bugs wrote:

(In reply to comment #0)

When I undo suppression of a revision, the action gets logged in the deletion
log, even though the original suppression gets logged in the suppression log.
This creates misleading results when using [[Special:Log/suppress]], since it's
impossible to tell that something was unsuppressed from the log without
checking the page's deletion log as well.

Perhaps the suppression log could show the set of deletion & suppression events? Alternatively, you could log unsuppression in both.

This should not be the case, unless some check is broken

Closing (works on svn head at least)

mcdevitd wrote:

Maybe I didn't explain it well; it is reproducible for me. This happens when I use the "Suppress data from administrators as well as others" box from the deletion page, and then restore from Special:Undelete. Basically, delete+suppress logs the action in the suppression log, but not the deletion log (which I think is the correct action), but restore+unsuppress (i.e., clicking the "restore" option on a suppressed article from Special:Undelete) logs the action in the deletion log but not the suppression log. These two create unbalanced logs as a result. For example, at http://en.wikipedia.org/w/index.php?title=Special:Log&page=User%3ADominic%2F there is a restoration with no corresponding deletion, because the original deletion was suppression-deletion. The suppression log for the page (not public) also has only a suppression and not the corresponding unsuppression.

Oh, *page suppression*. In that case, I suppose a quick hack would be to scrap the suppress log to decide what log to put the restoration event in...