Page MenuHomePhabricator

DBConnRefTest::testConstruct_failure Parameter must be an array or an object that implements Countable
Closed, DeclinedPublic

Description

1) DBConnRefTest::testConstruct_failure
count(): Parameter must be an array or an object that implements Countable
/var/www/html/includes/libs/rdbms/database/DBConnRef.php:36
/var/www/html/tests/phpunit/includes/libs/rdbms/database/DBConnRefTest.php:106
/var/www/html/maintenance/doMaintenance.php:94

Event Timeline

@Reedy, I can't reproduce this on PHP 7.2.11, PHPUnit 6.5.13

>mw-core (development-core)$ php tests/phpunit/phpunit.php tests/phpunit/includes/libs/rdbms/database/DBConnRefTest.php -v
Using PHP 7.2.11
PHPUnit 6.5.13 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.2.11
Configuration: /usr/local/var/www/wiki/mw-core/tests/phpunit/suite.xml

........                                                            8 / 8 (100%)

Time: 224 ms, Memory: 20.00MB

OK (8 tests, 12 assertions)

Everything passes, so please more lights. Maybe this fails on a particular MW version or PHP environment?

I don't actually know where I picked this failure up from, certainly not a local MW install.... And I don't think it's Vagrant, nor is it Travis

Krinkle subscribed.

Doesn't show up in our php72 CI, nor in Travis. Not actionable. Possibly fixed since.