Page MenuHomePhabricator
Create Task
Maniphest T201773

Deal with Ingenico Connect code 300620: MerchantReference XXXX already exists
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The MerchantReference numbers for Connect are ct_id.sequence, so we can just increment the sequence and try again.

Details

SubjectRepoBranchLines +/-
Ingenico: Don't send failmail on http 402 or 409wikimedia/fundraising/SmashPigmaster+7 -1
Un-cancel Ingenico recurring with duplicate merchant refwikimedia/fundraising/crmmaster+52 -0
Increment merchant ref and retry paymentwikimedia/fundraising/crmmaster+260 -54
SmashPig payment processor: expose API codeswikimedia/fundraising/crmmaster+61 -14
Customize query in gerrit

Event Timeline

Ejegg created this task.Aug 12 2018, 1:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2018, 1:10 AM
• DStrine added a project: Fundraising Sprint Pluto is still a planet.Aug 13 2018, 7:33 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
gerritbot subscribed.Aug 14 2018, 11:57 PM

Change 452871 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] SmashPig payment processor: expose API codes

https://gerrit.wikimedia.org/r/452871

gerritbot added a project: Patch-For-Review.Aug 14 2018, 11:57 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Pluto is still a planet board.Aug 17 2018, 4:20 PM
gerritbot added a comment.Aug 17 2018, 8:15 PM

Change 453479 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP increment merchant ref and retry payment

https://gerrit.wikimedia.org/r/453479

• DStrine added a project: Fundraising Sprint Queue is pronounced GJif.Aug 21 2018, 8:47 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Queue is pronounced GJif board.Aug 22 2018, 1:09 AM
Ejegg claimed this task.Aug 22 2018, 1:14 AM
Ejegg triaged this task as Medium priority.
Ejegg set the point value for this task to 2.
Ejegg moved this task from Doing to Review on the Fundraising Sprint Queue is pronounced GJif board.Aug 27 2018, 7:12 PM
gerritbot added a comment.Aug 30 2018, 11:28 PM

Change 456517 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP: Opt-in queue consumer

https://gerrit.wikimedia.org/r/456517

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Queue is pronounced GJif board.Aug 31 2018, 11:45 PM
Ejegg moved this task from Pending Deployment to Review on the Fundraising Sprint Queue is pronounced GJif board.Aug 31 2018, 11:56 PM
gerritbot added a comment.Sep 3 2018, 7:50 PM

Change 452871 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] SmashPig payment processor: expose API codes

https://gerrit.wikimedia.org/r/452871

gerritbot added a comment.Sep 3 2018, 7:52 PM

Change 453479 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Increment merchant ref and retry payment

https://gerrit.wikimedia.org/r/453479

Ejegg moved this task from Review to Done on the Fundraising Sprint Queue is pronounced GJif board.Sep 3 2018, 10:46 PM
• DStrine added a project: Fundraising Sprint Raw data can give you salmonella.Sep 4 2018, 8:37 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Raw data can give you salmonella board.Sep 5 2018, 3:23 PM
Ejegg added a comment.Sep 5 2018, 4:42 PM

Still TODO: find things we canceled for this reason and uncancel them so we can retry

gerritbot added a comment.Sep 6 2018, 9:25 PM

Change 458594 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Un-cancel Ingenico recurring with duplicate merchant ref

https://gerrit.wikimedia.org/r/458594

Ejegg moved this task from Done to Review on the Fundraising Sprint Raw data can give you salmonella board.Sep 6 2018, 9:25 PM
Ejegg added a comment.Sep 6 2018, 9:51 PM

I ran updb on dev and it didn't seem to fix them, but running the SQL directly did.

UPDATE civicrm_contribution_recur cr
INNER JOIN civicrm_contribution c ON c.contribution_recur_id = cr.id
INNER JOIN dev_drupal.contribution_tracking ct ON ct.contribution_id = c.id
SET cr.next_sched_contribution_date = DATE_ADD(
cr.start_date, INTERVAL 2 MONTH
),
cr.failure_count = 0,
cr.cancel_date = NULL,
cr.contribution_status_id = 1
WHERE ct.id IN (57990533, 57991947, 57995299, 57995622, 57997242, 58006880, 58007549, 58112187, 58113086, 58113202, 58117262, 58215150, 58218626, 58221282, 58223014, 58223512, 58228479, 58229787, 58232269, 58234072, 58235105, 58235341, 58239642, 58242471, 58243295, 58243359, 58246799, 58247903)
AND cr.contribution_status_id = 3;

gerritbot added a comment.Sep 6 2018, 11:00 PM

Change 458594 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Un-cancel Ingenico recurring with duplicate merchant ref

https://gerrit.wikimedia.org/r/458594

Ejegg moved this task from Review to Done on the Fundraising Sprint Raw data can give you salmonella board.Sep 6 2018, 11:19 PM
Ejegg moved this task from Done to Review on the Fundraising Sprint Raw data can give you salmonella board.Sep 10 2018, 7:32 PM
gerritbot added a comment.Sep 10 2018, 7:33 PM

Change 458941 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Ingenico: Don't send failmail on http 402 or 409

https://gerrit.wikimedia.org/r/458941

gerritbot added a comment.Sep 10 2018, 8:37 PM

Change 458941 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Ingenico: Don't send failmail on http 402 or 409

https://gerrit.wikimedia.org/r/458941

Ejegg moved this task from Review to Done on the Fundraising Sprint Raw data can give you salmonella board.Sep 11 2018, 3:59 PM
Ejegg closed this task as Resolved.Sep 18 2018, 7:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL