Page MenuHomePhabricator

Section edit links should pick correct section, or give warning, if sections have changed between view and edit
Closed, ResolvedPublic

Description

Currently if you click a section edit link, and sections have been added or removed ahead of it between your page load and your click, you'll end up at a different section than you expected.

It may not be 100% scientifically possible to always know which is the 'same' section, but if the number of sections has changed we should be able to at least estimate with confidence that things may not be as the user expected and give them a warning.

If we can find the right section (most of the time the heading text will be the same), then we could also pop over to it.

Including a version number or timestamp onto the link would probably be necessary to implement this.


Version: unspecified
Severity: enhancement

Details

Reference
bz18187

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:32 PM
bzimport set Reference to bz18187.
bzimport added a subscriber: Unknown Object (MLST).

Note to whoever's gonna poke at this: please consider the API edit module! It'd really suck if you'd get this working after some hard work just so I can rewrite half of it to make it cooperate nicely with the API.

The API is your friend, be nice to the API. :)

I'm not sure if this is the exact same thing, but when I edit this:

http://en.wikipedia.org/w/index.php?title=Wikipedia:SOPA_initiative/Action&action=edit&section=16

It should return me here when I click submit:

http://en.wikipedia.org/wiki/Wikipedia:SOPA_initiative/Action#Support_2

But instead it puts me here:

http://en.wikipedia.org/wiki/Wikipedia:SOPA_initiative/Action#Support

I have reloaded and edited several times, and no new sections have been added. This may be a separate, similar bug, but I'm not sure. Can someone confirm? If confirmed, I'd like to formally submit the bug and add it to my collection :)

*** This bug has been marked as a duplicate of bug 9958 ***