Page MenuHomePhabricator

Special:Redirect should give more specific error messages
Closed, ResolvedPublic

Description

All errors on Special:Redirect results in message 'redirect-not-exists', but the redirect can also not happen for invalid input.
For example the type=user and value= non-numeric shows the same as for non-exist user.

The special page should use more specific error messages. I would change all functions in dispatch() to return Status objects and have the url as value (Status::newGood( $url ))

For type=file the reason for the invalid title should be taken from MalformedTitleException (by TitleParser)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2018, 12:38 AM

Change 453559 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Give more specific error messages on Special:Redirect

https://gerrit.wikimedia.org/r/453559

Umherirrender triaged this task as Normal priority.
Florian closed this task as Resolved.Sep 16 2018, 7:16 PM

Change 453559 merged by jenkins-bot:
[mediawiki/core@master] Give more specific error messages on Special:Redirect

https://gerrit.wikimedia.org/r/453559

Change 538390 had a related patch set uploaded (by Reedy; owner: Umherirrender):
[mediawiki/core@REL1_31] Give more specific error messages on Special:Redirect

https://gerrit.wikimedia.org/r/538390

Change 538390 merged by jenkins-bot:
[mediawiki/core@REL1_31] Give more specific error messages on Special:Redirect

https://gerrit.wikimedia.org/r/538390