Page MenuHomePhabricator

Multiple issues box icon does not always match contents which might be confusing
Closed, InvalidPublic


When visiting

The banner displays like this

Screen Shot 2018-08-20 at 5.01.48 PM.png (171×427 px, 25 KB)

but upon expecting the overlay the 2 icons inside the issues do not match:

Screen Shot 2018-08-20 at 5.02.13 PM.png (333×210 px, 31 KB)

The problem stems from the fact that

  • sweep
    Screen Shot 2018-08-20 at 5.07.56 PM.png (37×33 px, 7 KB)
    is a low issue
  • balance
    Screen Shot 2018-08-20 at 5.07.58 PM.png (51×40 px, 7 KB)
    is a medium issue
  • we show the generic icon (in this case medium issue)

Developer notes

Showing the balance icon alongside "This article has multiple issues. Please help improve it or discuss these issues on the talk page." would be a little confusing

A few options

  • Update design to show all icons
  • Take the icon associated with the highest priority issue (in this case the balance icon) - possibly a little confusing.
  • Keep as is.

Event Timeline

This comment was removed by Jdlrobson.

I did not initially notice that this is a medium issue. This is the expected behavior, imo:

  • Given a page with an issue with severity X and severity Y, if severity X > severity Y, we display the generic icon for severity X

The reasoning here is that the icons do not need to match the icons of the issues themselves, as displaying the icon for one issue but not the other may be misleading. Rather, the icons need to display the overall severity of the group of issues, which is the severity of the issue with highest level severity.

So this is working as expected?

Just needed confirmation for multiple cases. Confirmed the following:

Medium and low shows medium
Low and low shows low
Low and notice defaults to low

Couldn't find a sample for high and medium/low, but I think we can assume it will work based on the above. Closing this, but feel free to reopen if there's remaining concerns.