Change 444951 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/core@master] Update: allow ResourceLoader selectorWithoutVariant to be overridden per image

https://gerrit.wikimedia.org/r/444951

Change 444952 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Update: page issue icons

https://gerrit.wikimedia.org/r/444952

Change 444951 abandoned by Niedzielski:
Update: allow ResourceLoader selectorWithoutVariant to be overridden per image

Reason:
Thanks for checking this out, Bartosz. I'm abandoning this patch for the time being until we're certain we need it.

https://gerrit.wikimedia.org/r/444951

@alexhollender / @ovasileva, if you have the time to take a quick peek at this before it's reviewed, I've posted the latest revision up here: http://reading-web-staging.wmflabs.org/.

@Niedzielski looking good. Here are some screenshots of the icon logic working correctly:

high	medium	low	notice	multiple (correctly displaying the icon of the higher severity issue)

Regarding the specialty icons, it seems like they are displaying in the modal but not in the banner:

Template:POV, banner	Template:POV, modal

I'm realizing that I never gave you a list of which templates to associate with the specialty icons.

• POV - I searched through Jan's page for all templates that use the Unbalanced scales.svg icon. There are 14 matches that seem appropriate:
  • Template:COI
  • Template:Coverage
  • Template:Criticism section
  • Template:Fringe theories
  • Template:GenderPOV
  • Template:NPOV language
  • Template:Paid contributions
  • Template:POV
  • Template:Pseudo
  • Template:Systemic bias
  • Template:Unbalanced
  • Template:Unbalanced section
  • Template:USgovtPOV
  • Template:Geographical imbalance (this one uses the scale as a secondary icon)

• Move - I searched for move/moved, there are 7 matches that seem appropriate:
  • Template:Converted
  • Template:Copy to Wikibooks
  • Template:Copy to Wikiversity
  • Template:DabprimaryExpand
  • Template:Dicdef
  • Template:InterTransWiki
  • Template:Not English (questionable)

@ovasileva @Niedzielski do these lists feel appropriate to you?

mw-ui-icon-minerva-issue-severity-medium-mediumColor looks blurry to me when rendered as a small icon

mw-ui-icon-minerva-issue-severity-medium-mediumColor looks blurry to me when rendered as a small icon

that's odd, the color also looks off (too dark)

that also reminds me, @Niedzielski would this be the appropriate ticket to talk about minor CSS tweaks to the icon element? Just changed this to 75% and the icons being slightly bigger looks nice:

.mw-ui-icon.mw-ui-icon-small:before {
    background-size: 75% auto;
}

In T191528#4421254, @Jdlrobson wrote:

mw-ui-icon-minerva-issue-severity-medium-mediumColor looks blurry to me when rendered as a small icon

Is that intentional?

it looks blurry to me as well, but the color seems fine. Everything else is looking really nice.

Regarding the specialty icons, it seems like they are displaying in the modal but not in the banner

Dang, I think I misunderstood the requirements. Fixed!

I'm realizing that I never gave you a list of which templates to associate with the specialty icons.

Updates below!

POV

• Template:COI .ambox-COI, already covered.
• Template:Coverage - Unsupported, no distinguishing CSS class.
• Template:Criticism section - Unsupported, no distinguishing CSS class.
• Template:Fringe theories - .ambox-fringe-theories, added. I did not notice any equivalent non-enwiki templates on Jan's chart.
• Template:GenderPOV - .ambox-POV, already covered.
• Template:NPOV language - .ambox-npov-language, already present.
• Template:Paid contributions - .ambox-COI, already covered.
• Template:POV - .ambox-POV, already covered.
• Template:Pseudo - Unsupported, no distinguishing CSS class.
• Template:Systemic bias - .ambox-systemic-bias, added. I did not notice any equivalent non-enwiki templates on Jan's chart.
• Template:Unbalanced - Unsupported, no distinguishing CSS class.
• Template:Unbalanced section - Unsupported, no distinguishing CSS class.
• Template:USgovtPOV - Unsupported, no distinguishing CSS class.
• Template:Geographical imbalance (this one uses the scale as a secondary icon) - Unsupported, no distinguishing CSS class.

Move

• Template:Converted - Unsupported, no distinguishing CSS class.
• Template:Copy to Wikibooks - .ambox-move, already covered.
• Template:Copy to Wikiversity - .ambox-move, already covered.
• Template:DabprimaryExpand - Unsupported, no distinguishing CSS class.
• Template:Dicdef - .ambox-move, already covered.
• Template:InterTransWiki - .ambox-move, already covered.
• Template:Not English (questionable) - I can identify this but the CSS class, .ambox-not_English, seems like it's going to differ on most wikis.

CSS tweaks

It seemed like an easy change so I just rolled it in!

blurry

Does "high.svg" need the same special low resolution integer considerations you made for the interwiki icons? See how they look at 75%.

..And I think that's it! The latest and greatest is up on reading-web-staging.wmflabs.org.

@ovasileva latest and greatest deployed on https://reading-web-staging.wmflabs.org/!

Change 444952 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update: page issue icons

https://gerrit.wikimedia.org/r/444952

@Niedzielski, I am having some trouble finding articles with the different severity levels on Beta and Devwiki. Is there some sort of search I can perform or do we have a list of representative articles on Beta or Devwiki?

@ABorbaWMF, I don't have a list for the beta cluster or devwiki but any page can be copied from enwiki to the beta cluster. Can you use readers-web-master? It's less stable (it resynchronizes every 15 minutes and may be unavailable during this time) but mirrors enwiki.

Change 450278 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Fix: page issue icon type determination

https://gerrit.wikimedia.org/r/450278

Not seeing scales icon on http://reading-web-staging.wmflabs.org/wiki/Fiorello_H._La_Guardia

Fixed.

Lots of issues with balanced templates+icon combo

In retrospect, I'm not sure what @Jdlrobson was alluding to. Would you mind clarifying this point and I'll check it out? Link to original discussion to help jog your memory.

Lots of issues with balanced templates+icon combo

This problem is impacting articles in item 6 of QA steps. Even with the latest merged patchset, the balanced icon is not showing on a couple of examples. I believe the heuristic for what constitutes a balanced template is broken.
There remain issues with 2 more articles:

• http://localhost:8888/w/index.php/Economy_of_Indonesia?useformat=mobile
• http://localhost:8888/w/index.php/XFS?useformat=mobile#Disadvantages

Change 450278 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix: page issue icon type determination

https://gerrit.wikimedia.org/r/450278

Change 451664 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Fix: add a few more POV templates to issue parser

https://gerrit.wikimedia.org/r/451664

Change 451664 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix: add a few more POV templates to issue parser

https://gerrit.wikimedia.org/r/451664

@Jdlrobson, should be fixed now. I didn't realize this earlier but I was able to edit the remaining requested templates and didn't need to touch the underlying ambox logic, although it would ideally use the name parameter to generate a unique class name. Not a sustainable approach but at least we're starting to get some the data structure into the templates themselves.

Issue 1

Alas, there seems to be a snag with multiple issues icons. The logic, as described above, "Use the default icon of the issue with the highest severity level among the multiple issues" was not specific enough (my fault). There are three unique cases of multiple issues:

1. all issues are within the multiple issues template	2. some issues are within the multiple issues template and some aren't	3. no issues are within the template
the icon should correspond to the highest level issue within the group	for the multiple issues banner the icon should correspond to the highest level issue within the group, any stray issues should keep their own icons	all issues should keep their own icons

The only caveat to this might be if we've got worked planned to somehow deal with cases 2 & 3 above at a higher level (such as forcing the stray issues into the multiple issues template). @Jdlrobson any idea if that's the case? If so it might not be worth fixing these here.

Issue 2

Secondly, there's are some background and text highlight colors that seem to have slipped through our dragnet:

Template:Afd-merge to	Template:Wikify
example: http://reading-web-staging.wmflabs.org/wiki/BuyMyFace	example: http://reading-web-staging.wmflabs.org/wiki/Joint_Committee_for_Guides_in_Metrology

Might also be worth stress testing Template:No political diagram and Template:Copypaste

I recognize that this doesn't really fit in the scope of this task. Currently we don't have a general styling task, however I'm more than happy to make a separate ticket for this issue (which isn't critical) and so we can keep this moving along.

Change 452573 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: move page issues A/B test logging to file

https://gerrit.wikimedia.org/r/452573

@alexhollender, I'm still digging through the code to respond to your feedback. I've had to restructure some things to understand them better and hope to have answers tomorrow.

Change 452683 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: don't hardcode page issue header selector

https://gerrit.wikimedia.org/r/452683

Change 452700 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: move page issue overlay to distinct file

https://gerrit.wikimedia.org/r/452700

Change 452573 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: move page issues A/B test logging to file

https://gerrit.wikimedia.org/r/452573

New task created for the background color issue T202024

Change 452683 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: don't hardcode page issue header selector

https://gerrit.wikimedia.org/r/452683

@Niedzielski not sure if this is helpful, but I believe this page verifies that the multiple issue logic isn't surfacing the icon from the highest level issue among the multiple. In this case the issue displayed in the banner doesn't match either of the issue icons in the modal: https://reading-web-staging.wmflabs.org/wiki/Musical_film

In T191528#4508264, @alexhollender wrote:

@Niedzielski not sure if this is helpful, but I believe this page verifies that the multiple issue logic isn't surfacing the icon from the highest level issue among the multiple. In this case the issue displayed in the banner doesn't match either of the issue icons in the modal: https://reading-web-staging.wmflabs.org/wiki/Musical_film

@alexhollender, @Niedzielski - I think this is correct behavior. I would expect the behavior to display the default icon for the severity level we are looking at, rather than the icon itself. For example, if there's two multiple issues that have the same severity, it would not make sense to distinguish them with only the icon of one of the issues, but rather with the default icon of the severity.

Spoke with Olga on Slack and just wanted to clarify: in the case above (https://reading-web-staging.wmflabs.org/wiki/Musical_film) the icon on the multiple issues banner should be a broom.

There is an additional point that wasn't addressed in my table here T191528#4499627, which is, in case #1 what if the highest severity issue is one that uses a speciality icon (e.g. POV, which is a "medium" level issue)? In that case would it be confusing for the multiple issues banner to take on the speciality icon? From a design perspective it would be great if we could fall-back to the generic icon for that severity level in the case of the multiple issues banner, but not sure how much additional complexity that introduces.

On a related note, @Jdlrobson @ovasileva do we currently have a plan to deal with situations #2 and #3 listed here T191528#4499627?

@alexhollender having reviewed https://phabricator.wikimedia.org/T191528#4499627 I think the issues here relate to editors failing to use the "Template:Multiple issues". When this is not used, the code is subject to bugs. If these are deal breakers, let's follow up in T202349. I think this is a sufficient creep in scope for this task.

The issue you raise in https://phabricator.wikimedia.org/T191528#4515454 is not ready for development, I've created T202351 to talk more.

The problem with lumping all this work into this task, is making it hard to keep track of work, so let's wrap this task up provided those are the only 2 remaining issues.

In T191528#4517291, @Jdlrobson wrote:

@alexhollender having reviewed https://phabricator.wikimedia.org/T191528#4499627 I think the issues here relate to editors failing to use the "Template:Multiple issues". When this is not used, the code is subject to bugs. If these are deal breakers, let's follow up in T202349. I think this is a sufficient creep in scope for this task.

I agree. Let's discuss this part separately.

From the QA Steps in the description. Still working on Step 6.

1. Severe - http://reading-web-staging.wmflabs.org/w/index.php?title=Tune_Smithy&mobileaction=toggle_view_mobile

2. High Priority - http://reading-web-staging.wmflabs.org/w/index.php?title=Duke_Nukem_3D&mobileaction=toggle_view_mobile

3. Sweep - http://reading-web-staging.wmflabs.org/w/index.php?title=Transport_in_Cape_Verde&mobileaction=toggle_view_mobile

4. Gray triangle - http://reading-web-staging.wmflabs.org/w/index.php?title=Asparagales&mobileaction=toggle_view_mobile

5. Multiple issues: http://reading-web-staging.wmflabs.org/w/index.php?title=Ainu_people&mobileaction=toggle_view_mobile

6. Neutrality balance icon (scales) - URLs above

Change 452700 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: move page issue overlay to distinct file

https://gerrit.wikimedia.org/r/452700