Page MenuHomePhabricator
Create Task
Maniphest T202823

Page using FormWizard parser function results in errors
Closed, ResolvedPublic
Actions

Description

https://collaborationkit.wmflabs.org/w/index.php/FormWizard?action=purge

Page contents:

{{#formwizard:Test.json}}

Shows these errors:

Warning: Missing argument 3 for FormWizardHooks::showProjectButton(), called in /var/www/html/w/includes/parser/Parser.php on line 3442 and defined in /var/www/html/w/extensions/FormWizard/Hooks.php on line 72

Warning: Missing argument 4 for FormWizardHooks::showProjectButton(), called in /var/www/html/w/includes/parser/Parser.php on line 3442 and defined in /var/www/html/w/extensions/FormWizard/Hooks.php on line 72

Warning: Missing argument 5 for FormWizardHooks::showProjectButton(), called in /var/www/html/w/includes/parser/Parser.php on line 3442 and defined in /var/www/html/w/extensions/FormWizard/Hooks.php on line 72

Warning: Missing argument 6 for FormWizardHooks::showProjectButton(), called in /var/www/html/w/includes/parser/Parser.php on line 3442 and defined in /var/www/html/w/extensions/FormWizard/Hooks.php on line 72

Notice: Undefined variable: action in /var/www/html/w/extensions/FormWizard/Hooks.php on line 81

Notice: Undefined variable: config in /var/www/html/w/extensions/FormWizard/Hooks.php on line 84

Notice: Undefined variable: pageName in /var/www/html/w/extensions/FormWizard/Hooks.php on line 85

Notice: Undefined variable: pageType in /var/www/html/w/extensions/FormWizard/Hooks.php on line 86

Details

SubjectRepoBranchLines +/-
Page using FormWizard parser function results in errorsmediawiki/extensions/FormWizardmaster+542 -599
Customize query in gerrit

Related Objects

Event Timeline

Harej created this task.Aug 26 2018, 1:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2018, 1:54 AM
Eugene233 added a comment.Aug 26 2018, 5:39 AM

According to documentation, I could have the button from the below image @Harej

Screen Shot 2018-08-26 at 6.38.44 AM.png (263×886 px, 41 KB)

Eugene233 claimed this task.Aug 26 2018, 5:40 AM

Primarily I can say that the log shows that all the arguments were not given to the parser function as required.

Harej added a comment.Sep 5 2018, 8:58 PM

In the event of missing fields, the error should be handled through an error message generated by MediaWiki. It should not result in PHP-level exceptions.

Eugene233 added a comment.Sep 5 2018, 9:04 PM

That makes a lot more sense @Harej.

Eugene233 moved this task from Backlog to Tasks in progress(Doing) on the FormWizard board.Jan 4 2019, 2:25 PM
gerritbot subscribed.Jan 4 2019, 2:35 PM

Change 482303 had a related patch set uploaded (by Eugene233; owner: Eugene233):
[mediawiki/extensions/FormWizard@master] Page using FormWizard parser function results in errors.

https://gerrit.wikimedia.org/r/482303

gerritbot added a project: Patch-For-Review.Jan 4 2019, 2:35 PM
Eugene233 mentioned this in rEFWZ7b26e9e6e2d6: Page using FormWizard parser function results in errors..Jan 4 2019, 2:36 PM
Eugene233 mentioned this in rEFWZd60643263d69: Page using FormWizard parser function results in errors..Jan 9 2019, 3:03 PM
Eugene233 mentioned this in rEFWZe0fe69258922: Page using FormWizard parser function results in errors..Jan 9 2019, 3:16 PM
Eugene233 mentioned this in rEFWZ0081b12561a6: Page using FormWizard parser function results in errors..
Eugene233 mentioned this in rEFWZ4f233b3ea58a: Page using FormWizard parser function results in errors.Jan 14 2019, 12:19 PM
Eugene233 mentioned this in rEFWZa19830432409: Page using FormWizard parser function results in errors.Jan 14 2019, 12:43 PM
Eugene233 mentioned this in rEFWZbbe2aeec5902: Page using FormWizard parser function results in errors.Jan 15 2019, 2:48 PM
Eugene233 mentioned this in rEFWZe1e8520576f7: Page using FormWizard parser function results in errors.Jan 18 2019, 9:24 AM
Eugene233 mentioned this in rEFWZffd79e31187e: Page using FormWizard parser function results in errors.
Eugene233 mentioned this in rEFWZcd88e56cc20b: Page using FormWizard parser function results in errors.Jan 19 2019, 3:07 AM
Eugene233 mentioned this in rEFWZ69f10d40d73f: Page using FormWizard parser function results in errors.Jan 21 2019, 12:32 PM
Eugene233 mentioned this in rEFWZ57740adf6497: Page using FormWizard parser function results in errors.Feb 18 2019, 6:30 PM
jijiki mentioned this in rEFWZ6182ed51c7b2: Page using FormWizard parser function results in errors.Mar 18 2019, 4:29 PM
gerritbot added a comment.May 24 2019, 10:02 AM

Change 482303 had a related patch set uploaded (by Eugene233; owner: Eugene233):
[mediawiki/extensions/FormWizard@master] Page using FormWizard parser function results in errors

https://gerrit.wikimedia.org/r/482303

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 24 2019, 10:02 AM
Eugene233 mentioned this in rEFWZ2ff986ed0919: Page using FormWizard parser function results in errors.May 24 2019, 10:04 AM
Eugene233 mentioned this in rEFWZ3b2b43c546c3: Page using FormWizard parser function results in errors.May 24 2019, 10:21 AM
Eugene233 mentioned this in rEFWZ262a7d148835: Page using FormWizard parser function results in errors.May 24 2019, 12:15 PM
Eugene233 mentioned this in rEFWZ0c42e6cfbb30: Page using FormWizard parser function results in errors.Jun 17 2019, 9:58 AM
gerritbot added a comment.Aug 8 2019, 10:46 AM

Change 482303 merged by jenkins-bot:
[mediawiki/extensions/FormWizard@master] Page using FormWizard parser function results in errors

https://gerrit.wikimedia.org/r/482303

Harej unsubscribed.Feb 11 2020, 12:05 AM
Aklapper closed this task as Resolved.Oct 14 2020, 8:47 PM

@Eugene233: The patch in Gerrit was merged, so I am assuming that this task can be resolved. If not and there is more work to do, then please reopen. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits