Reproduce step:
- Edit any pages (Ex. https://zh.wikipedia.org/w/index.php?title=Wikipedia:%E6%B2%99%E7%9B%92&action=edit )
- Click "Embedded file"
- Click "Upload"
- Got message "⧼apierror-permissiondenied⧽"
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mediawiki.Upload.BookletLayout: Add missing message | mediawiki/core | master | +1 -0 |
Event Timeline
Comment Actions
Confirming. After clicking "Upload file" the call goes to
https://zh.wikipedia.org/w/api.php?action=query&format=json&errorformat=html&errorlang=en&errorsuselocal=1&formatversion=2&meta=userinfo&uiprop=groups%7Crights
On other sites like cs.wp I get the expected File Upload dialog.
Comment Actions
If you have the "upload" permission, the "Upload file" dialog will be displayed correctly. For those users without "upload" right, It should display the message "You don't have permission to $1." instead of "apierror-permissiondenied".
Comment Actions
But the bug is real, and it might affect other wikis, since we are actually not loading the 'apierror-permissiondenied' message.
This no longer affects zhwiki, since the upload dialog has been disabled via wiki configuration, now it shows the 'upload-dialog-disabled' message, which works correctly:
But the bug is real, and it might affect other wikis, since we are actually not loading the 'apierror-permissiondenied' message.
Comment Actions
Change 526824 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mediawiki.Upload.BookletLayout: Add missing message
Comment Actions
Change 526824 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.Upload.BookletLayout: Add missing message