Description
Details
Related Objects
- Mentioned In
- T203584: Throttle groups may be empty or include unknown stuff
- Mentioned Here
- T203359: Simplify throttle-related method after maintenance script execution
T196984: Validate action parameters client-side
T203336: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null
Event Timeline
Change 457394 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Reject empty warning messages when validating a filter
The "warning" part is the only one to do in this task. However, as I was saying in the commit message, this opens a new follow-up: currently, when executing the "warn" action, we check if the specified message is a string with length > 0. If it isn't, then the "abusefilter-warning" is used. The patch above prevents empty messages, so as soon as every invalid filter will be modified adding a message, above check won't be necessary. This means that, as for T203359, the code could be simplified, but it can't be done right now. Again, should we add a wfDeprecated for those cases?
Change 457424 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Overhaul tag selector
Change 457394 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Reject empty warning and disallow messages when validating a filter
Change 457424 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Overhaul tag selector