After the normalization from the maintenance script in T203336, throttle parameters will have the same order and the same form for every filter (before they were arrays where an element could consist of several comma-imploded groups). This means that we will be able to simplify the throttleKey function, where the second parameter will always be a string, which in turn would not only make the code cleaner, but have separate cache keys for every action.
However, I'm not sure how this should work: emit a wfDeprecated if $types is not a string, then remove extra logic in a subsequent MediaWiki release?
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Throw an exception if update.php has not been executed | mediawiki/extensions/AbuseFilter | master | +22 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T209023 Major overhaul for AbuseFilter | |||
| Open | None | T203587 Major overhaul for "throttle" action in AbuseFilter | |||
| Invalid | Daimona | T203359 Simplify throttle-related method after maintenance script execution |
Event Timeline
Comment Actions
Change 458827 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Throw an exception if update.php has not been executed
Comment Actions
Since the maintenance script has been changed to extend LoggedUpdateMaintenance, it'll be automatically executed in update.php. Throwing an exception is the first step; then, the related code should be removed. I just don't know how much time it should be left. In case this gets merged before 1.33, would it be enough to remove it in 1.33?
Comment Actions
Change 458827 abandoned by Daimona Eaytoy:
Throw an exception if update.php has not been executed
Reason:
Per T203587#4569698