Maniphest T209023

Major overhaul for AbuseFilter
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Daimona
	Nov 8 2018, 8:38 AM

Description

Several parts of our codebase are either outdated, flaky, or in general need to be rewritten. This is a task to track all of these major overhauls.

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T209023 Major overhaul for AbuseFilter
Open		None	T208842 Create a front end for making unit tests for filters
Open		None	T193064 Create a dedicated page for stats
Open		None	T191428 Enhance filter profiling
Resolved		Daimona	T191430 Re-enable profiling for stashed edits
Resolved		Daimona	T191039 Re-enable filter profiling on every wiki
Resolved		Daimona	T53294 Overhaul internal profiling system
Open		None	T87862 Show AbuseFilter average run time and used conditions in main table
Open		None	T90754 Allow tracking of max run time / conditions consumed in AbuseFilter
Resolved		MusikAnimal	T177017 Re-enable per-filter profiling on wikis where it was disabled
Resolved		• TBolliger	T177641 Enable AbuseFilter per-filter profiling on Portuguese Wikipedia & monitor if there is a performance impact
Resolved		• TBolliger	T179323 Enable AbuseFilter per-filter profiling on English Wikipedia & monitor if there is a performance impact
Resolved		Daimona	T132925 AbuseFilter statistics (but not "profiling" data) are reset every 10000 actions
Open		None	T179604 Move AbuseFilter slow filters data from Logstash to per-filter profiling
Declined		None	T176895 Surface slow filters and total condition count directly on Special:AbuseFilter
Open		None	T193375 Use the problems' dedicated page instead of tags to show actions which hit the condition limit
Open		None	T203587 Major overhaul for "throttle" action in AbuseFilter
Resolved	PRODUCTION ERROR	Daimona	T203336 Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null
Invalid		Daimona	T203359 Simplify throttle-related method after maintenance script execution
Open		None	T203554 Rewrite throttle parameters
Resolved		Daimona	T203584 Throttle groups may be empty or include unknown stuff
Resolved	PRODUCTION ERROR	Daimona	T203535 PHP Error "Undefined index: 1 in AbuseFilter.php on line 928"
Resolved		Daimona	T203585 Throttle parameters may have an undesired comma inside
Open		None	T196995 Should we log filter hits for actions that were only throttled?
Open		None	T24623 do not set throttle on warn action
Resolved		Daimona	T195699 "Throttle" action seems to malfunction randomly
Resolved		Daimona	T211101 Throttle identifiers are ambiguous
Resolved		Daimona	T215787 PHP Warning: "count(): Parameter must be an array or an object that implements Countable" on AbuseFilter history with PHP7
Resolved		Urbanecm	T209565 Dry run for normalizeThrottleParameters.php