Enable AbuseFilter per-filter profiling on English Wikipedia & monitor if there is a performance impact
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• TBolliger
	Oct 30 2017, 6:40 PM

Description

Based on the findings in T177641: Enable AbuseFilter per-filter profiling on Portuguese Wikipedia & monitor if there is a performance impact (specifically in comment T177641#3713701) we found no noticeable performance impact for 75p but a potential bump for 99p.

This ticket is to re-enable the per-filter profiling and monitoring (in the same way as monitored and evaluated for PTWP) if there is a performance impact. If there is no impact, we will leave the profiling enabled. If there is a noticeable impact (exact amount TBD, pending discussion) then the profiling will be disabled again.

Details

	Subject	Repo	Branch	Lines +/-
	Enable per-filter profiling on enwiki	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T209023 Major overhaul for AbuseFilter
Open	None	T193064 Create a dedicated page for stats
Open	None	T191428 Enhance filter profiling
Resolved	Daimona	T191430 Re-enable profiling for stashed edits
Resolved	Daimona	T191039 Re-enable filter profiling on every wiki
Resolved	MusikAnimal	T177017 Re-enable per-filter profiling on wikis where it was disabled
Resolved	• TBolliger	T179323 Enable AbuseFilter per-filter profiling on English Wikipedia & monitor if there is a performance impact

Event Timeline

Left as a 1 story point because the PTWP ticket was also a 1.

• TBolliger mentioned this in T177641: Enable AbuseFilter per-filter profiling on Portuguese Wikipedia & monitor if there is a performance impact.Oct 30 2017, 6:41 PM

• TBolliger mentioned this in T179604: Move AbuseFilter slow filters data from Logstash to per-filter profiling.Nov 2 2017, 6:32 PM

• TBolliger mentioned this in T176895: Surface slow filters and total condition count directly on Special:AbuseFilter.Nov 2 2017, 11:07 PM

• TBolliger moved this task from Cards ready for development to AHT Sprint 9 on the Anti-Harassment board.Nov 6 2017, 9:56 PM

• TBolliger edited projects, added Anti-Harassment (AHT Sprint 9); removed Anti-Harassment.

dmaza claimed this task.Nov 8 2017, 8:12 PM

dmaza moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 9) board.Nov 8 2017, 9:44 PM

Change 390153 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[operations/mediawiki-config@master] Enable per-filter profiling on enwiki

https://gerrit.wikimedia.org/r/390153

gerritbot added a project: Patch-For-Review.Nov 8 2017, 9:49 PM

dmaza moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 9) board.Nov 8 2017, 9:51 PM

Change 390153 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable per-filter profiling on enwiki

https://gerrit.wikimedia.org/r/390153

Mentioned in SAL (#wikimedia-operations) [2017-11-13T19:18:40Z] <thcipriani@tin> Synchronized wmf-config/abusefilter.php: SWAT: [[gerrit:390153|Enable per-filter profiling on enwiki]] T179323 (duration: 00m 45s)

I'll take this task and calculate it how I calculated T177641

I exported data from Grafana:

grafana_data_export.csv131 KBDownload

I calculated the average for 48 hours before and after 2017-11-11 at 11:15. The data is in milliseconds:

	Before	After	Difference	% Change
99th percentile	241.03	250.47	+9.44	3.92%
75th percentile	43.05	44.83	+1.78	4.13%

This is very similar to the results from PTWP (T177641#3713701) so I don't believe there is any need to revert at this time. In brief, there appears to be a minimal decrease in performance after the release of the per-filter profiling, but as it is 1.78MS for 75p and 9.44MS for 99p, I feel it is probably an acceptable change.

I think we're good to leave it enabled for now, and I can re-calculate this data next Monday after a full week of data, to account if there are any weekend fluctuations. Thoughts, anyone?

From this Grafana data:

grafana_data_export.csv124 KBDownload

I calculated (spreadsheet) the average for 7 days before and after 2017-11-11 at 11:15. The data is in milliseconds:

	Before	After	Difference	% Change
99th percentile	238.71	239.91	1.20	0.50%
75th percentile	43.76	45.63	1.87	4.27%

Seeing that 75% of edits are only seeing an additional 0.00187 second delay, I think it's safe to state there is not noteworthy performance increase in re-enabling this profiling, I think we can move forward with T177017: Re-enable per-filter profiling on wikis where it was disabled and an on-wiki discussion about T176895: Surface slow filters and total condition count directly on Special:AbuseFilter

• TBolliger closed this task as Resolved.Nov 21 2017, 12:41 AM

• TBolliger moved this task from Review to Done on the Anti-Harassment (AHT Sprint 9) board.

• TBolliger mentioned this in T177017: Re-enable per-filter profiling on wikis where it was disabled.