Page MenuHomePhabricator

do not set throttle on warn action
Open, LowPublic

Description

If a throttle and warning is enabled on filter, the edit is counted also when the warning is shown. I think it should only count for the limit if an edit is taken or denied and not on warning, because the user sometimes don't know that he isn't allowed to take this action before he has read the warning message.

Counting at denied action (after warning) could be useful because at that time the user should known what he does.

See Also: T49493

Details

Reference
bz22623

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:05 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz22623.
bzimport added a subscriber: Unknown Object (MLST).

Change 462931 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Filter out actions to execute before actually executing them

https://gerrit.wikimedia.org/r/462931

Daimona added a subscriber: Daimona.

I want to make it clear that the patch above addresses a very similar, but yet different situation: if a filter X is only warning, every other filter other than X won't have its throttle counter increased. This is a non-controversial change, and to me it looks like something that just wasn't take into account when writing the logic. The throttle counter of the warning filter is however still updated, as that's a pretty different change, and I'm not sure that we want to fix it, given that it would be a breaking change for existing filters.

Change 462931 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Filter out actions to execute before actually executing them

https://gerrit.wikimedia.org/r/462931

Daimona removed a project: Patch-For-Review.

I've removed this part from the patch above, because this is not a straightforward change and it needs more discussion. Nonetheless, I'm still going to refactor the logic for handling consequences, so this will turn out to be a technically-easy change.