If a throttle and warning is enabled on filter, the edit is counted also when the warning is shown. I think it should only count for the limit if an edit is taken or denied and not on warning, because the user sometimes don't know that he isn't allowed to take this action before he has read the warning message.
Counting at denied action (after warning) could be useful because at that time the user should known what he does.
See Also: T49493
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T209023 Major overhaul for AbuseFilter | |||
| Open | None | T203587 Major overhaul for "throttle" action in AbuseFilter | |||
| Open | None | T24623 do not set throttle on warn action |
Change 462931 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Filter out actions to execute before actually executing them
I want to make it clear that the patch above addresses a very similar, but yet different situation: if a filter X is only warning, every other filter other than X won't have its throttle counter increased. This is a non-controversial change, and to me it looks like something that just wasn't take into account when writing the logic. The throttle counter of the warning filter is however still updated, as that's a pretty different change, and I'm not sure that we want to fix it, given that it would be a breaking change for existing filters.
Change 462931 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Filter out actions to execute before actually executing them
I've removed this part from the patch above, because this is not a straightforward change and it needs more discussion. Nonetheless, I'm still going to refactor the logic for handling consequences, so this will turn out to be a technically-easy change.