@MusikAnimal Do you know why on extension.json AbuseFilterRestrictions has the key flag, but AbuseFilterActions doesn't? Was flag an action and is not anymore?

In T175221#3594129, @dmaza wrote:

@MusikAnimal Do you know why on extension.json AbuseFilterRestrictions has the key flag, but AbuseFilterActions doesn't? Was flag an action and is not anymore?

Might be related to T154091. All enabled filters are "flagged" in the AbuseLog. So while you might consider it an action, there's no way to disable it (nor should you be able to).

Agreed, definitely. This variable should only be used for point 1. Using it for point 2 should be fine, but I agree that we should split them. The one in point 3 makes few sense, and really needs to be split. Point 4 instead is completely wrong. Actually, we should completely rework the way AbuseFilter takes actions: instead of doing it on the fly, it should first iterate through all actions to perform, then choose the ones to apply following a given priority, and then actually do them. This was alrady done for blocks in order to choose the longest duration, and would make T24623 a lot easier. It would also make really clear the action priority, and of course it would automatically avoid double warnings.

I'd make the change this way:

1. Keep $wgAbuseFilterRestrictions as it is, and use it for point 1
2. For point 2, add a new variable like $wgAbuseFilterDangerousActions
3. Add $wgAbuseFilterBlockingActions for point 3 and 4 (they're used for the same reason), and rename $wgAbuseFilterDisallowGlobalLocalBlocks to $wgAbuseFilterLocallyDisableGlobalBlockingActions

Then make the change in WMF config and copy these lines for new variables.

UPDATE: I was thinking that blocking actions are actually a hardcoded list. So I guess for point 3 and 4 we should add a variable named $wgAbuseFilterOtherBlockingActions with a default of [], and retrieve it using a functions which merges the variable with the hardcoded list. Also, for locally blocking global actions, we could add another variable named $wgAbuseFilterLocallyDisableGlobalActions which should then be an array of actions to disable.

Change 462123 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Split $wgAbuseFilterRestrictions in more specific variables

https://gerrit.wikimedia.org/r/462123

Change 462123 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Split $wgAbuseFilterRestrictions in more specific variables

https://gerrit.wikimedia.org/r/462123

(Note that I changed my mind and removed DangerousActions. The actions being disabled upon throttling are not something people are supposed to change, I believe)

Change 462123 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Replace $wgAbuseFilterRestrictions with more specific variables

https://gerrit.wikimedia.org/r/462123