Maniphest T203449

page-issues display incorrect icons when multiple issues in section
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	Jdrewniak
	Sep 4 2018, 9:59 AM

Description

When a section has multiple issues, all issues display the icon of highest-severity issue, instead of the icon that corresponds to the individual issue.


incorrect icons on the page	correct icons in the modal

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: move page issue group parsing to parser	mediawiki/skins/MinervaNeue	page-issues-cleanup	+46 -20
	Hygiene: move page issue group parsing to parser	mediawiki/skins/MinervaNeue	page-issue-fixes	+46 -20

Customize query in gerrit

Event Timeline

Jdrewniak created this task.Sep 4 2018, 9:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2018, 9:59 AM

Jdrewniak moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 4 2018, 12:28 PM

ovasileva triaged this task as High priority.Sep 4 2018, 2:28 PM

Jdlrobson closed this task as a duplicate of T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..Sep 4 2018, 3:05 PM

Change 457928 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Fix page-issue icons for multiple issues in a single section

https://gerrit.wikimedia.org/r/457928

gerritbot added a project: Patch-For-Review.Sep 4 2018, 3:33 PM

Change 458557 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: move page issue group parsing to parser

https://gerrit.wikimedia.org/r/458557

Change 464564 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: move page issue group parsing to parser

https://gerrit.wikimedia.org/r/464564

Change 458557 abandoned by Niedzielski:
Hygiene: move page issue group parsing to parser

Reason:
Moved to master branch since we don't seem to be using the page-issue-fixes branch. Unfortunately, using the same change ID and pushing for master created a second patch instead of updating this one: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/ /464564/.