Page MenuHomePhabricator
Create Task
Maniphest T203917

Remove addOnloadHook from Special:BibManagerList
Closed, ResolvedPublic
Actions

Description

ext.bibManager.List.js file is using addOnloadHook, which should be removed.

Do

Remove addOnloadHook and use jquery. Also, use OOUI elements.

Before:
Firefox_Screenshot_2018-09-09T18-46-28.598Z.png (726×1 px, 83 KB)
and After:
Firefox_Screenshot_2018-09-09T18-49-30.857Z.png (748×1 px, 84 KB)

Details

SubjectRepoBranchLines +/-
Use jQuery instead of addOnloadHookmediawiki/extensions/BibManagermaster+15 -16
Customize query in gerrit

Event Timeline

Jayprakash12345 created this task.Sep 9 2018, 6:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2018, 6:42 PM
gerritbot subscribed.Sep 9 2018, 6:55 PM

Change 459393 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/BibManager@master] Use jQuery instead of addOnloadHook

https://gerrit.wikimedia.org/r/459393

gerritbot added a project: Patch-For-Review.Sep 9 2018, 6:55 PM
Jayprakash12345 added a project: MediaWiki-extensions-Other.Sep 9 2018, 6:56 PM
Jayprakash12345 moved this task from Backlog to Configured on the User-Jayprakash12345 board.
Jayprakash12345 updated the task description. (Show Details)Sep 9 2018, 7:13 PM
Liuxinyu970226 added subscribers: Osnard, Tweichart.Sep 12 2018, 11:37 AM
gerritbot added a comment.Sep 13 2018, 4:43 PM

Change 459393 merged by jenkins-bot:
[mediawiki/extensions/BibManager@master] Use jQuery instead of addOnloadHook

https://gerrit.wikimedia.org/r/459393

Jayprakash12345 closed this task as Resolved.Sep 13 2018, 4:45 PM
Jayprakash12345 triaged this task as Medium priority.
Jayprakash12345 removed a project: Patch-For-Review.
Jayprakash12345 removed a subscriber: gerritbot.
Peachey88 edited projects, added MediaWiki-extensions-BibManager; removed MediaWiki-extensions-Other.Feb 23 2020, 1:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL