Page MenuHomePhabricator
Create Task
Maniphest T204775

Outreachy microtask: Writing Echo node.js tests (#2)
Closed, ResolvedPublic
Actions

Description

This is the second microtask for Outreachy applicants for T204068: QA: Automation Testing - port Echo Notification tests to Node.js. The task should be done after the first one: T204771: Outreachy microtask: Automation testing framework setup and running existing Echo node.js tests (#1).

TODO
Done

470729 (Abandoned): Test: notify a new user with welcome message
471909 (Abandoned): Test: notify a new user with welcome message
471910 (Abandoned): Test: notify a new user with welcome message

Details

SubjectRepoBranchLines +/-
Test: notify a new user with welcome messagemediawiki/extensions/Echomaster+30 -2
Test: notify a new user with welcome messagemediawiki/extensions/Echomaster+20 -21
Test: notify a new user with welcome messagemediawiki/extensions/Echomaster+32 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Sep 18 2018, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2018, 9:04 PM
Etonkovidova mentioned this in T204068: QA: Automation Testing - port Echo Notification tests to Node.js.Sep 18 2018, 9:06 PM
zeljkofilipin added a parent task: T204068: QA: Automation Testing - port Echo Notification tests to Node.js.Sep 19 2018, 8:19 AM
zeljkofilipin subscribed.
srishakatux edited projects, added Outreachy (Round 17); removed Outreachy.Sep 19 2018, 7:25 PM
srishakatux moved this task from Backlog to Microtasks on the Outreachy (Round 17) board.
MaroonPixel subscribed.Sep 29 2018, 4:23 AM
huyen_thi_ha subscribed.Oct 4 2018, 9:28 PM
Ephemeralwaves subscribed.Oct 7 2018, 9:08 PM
Ephemeralwaves added a comment.Oct 7 2018, 9:32 PM

Hi all, I'm working on writing a test to check for the welcome notification. I have emailed Etonkovidova a draft.

MaroonPixel added a comment.Oct 10 2018, 4:57 AM

Hello! @Aklapper @zeljkofilipin @Etonkovidova, do the Outreachy applicants have to send tests to @Etonkovidova?
I've also tried writing and running a test, but didn't know what I have to do with it. 😅

Aklapper added a comment.Oct 10 2018, 10:43 PM

@MaroonPixel: I assume new tests should end up in the codebase where other tests already are. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to propose patches (code changes) for review in Gerrit. Thanks!

MaroonPixel added a comment.Oct 11 2018, 2:44 PM

Thanks @Aklapper 😄

Arkadiy_Voronov subscribed.Oct 17 2018, 7:21 AM
gerritbot subscribed.Oct 30 2018, 11:35 PM

Change 470729 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/Echo@master] Update Echo.page.js::check for welcome element, Fix Echo.js::added page load, Add notification_welcome test

https://gerrit.wikimedia.org/r/470729

gerritbot added a project: Patch-For-Review.Oct 30 2018, 11:35 PM
gerritbot added a comment.Nov 6 2018, 4:42 AM

Change 471909 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/Echo@master] Test: notify a new user with welcome message

https://gerrit.wikimedia.org/r/471909

gerritbot added a comment.Nov 6 2018, 5:09 AM

Change 471910 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/Echo@master] Test: notify a new user with welcome message

https://gerrit.wikimedia.org/r/471910

gerritbot added a comment.Nov 29 2018, 3:04 AM

Change 471910 abandoned by Jforrester:
Test: notify a new user with welcome message

Reason:
In favour of I172e7b16d.

https://gerrit.wikimedia.org/r/471910

gerritbot added a comment.Nov 30 2018, 12:46 PM

Change 470729 abandoned by Aklapper:
Test: notify a new user with welcome message

https://gerrit.wikimedia.org/r/470729

gerritbot added a comment.Dec 17 2018, 4:54 PM

Change 471910 restored by Zfilipin:
Test: notify a new user with welcome message

https://gerrit.wikimedia.org/r/471910

gerritbot added a comment.Dec 17 2018, 4:55 PM

Change 471909 abandoned by Zfilipin:
Test: notify a new user with welcome message

Reason:
Fixed white-space in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/ /471910

https://gerrit.wikimedia.org/r/471909

zeljkofilipin claimed this task.Dec 18 2018, 12:58 PM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptDec 18 2018, 12:59 PM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Dec 18 2018, 12:59 PM
zeljkofilipin triaged this task as Medium priority.Dec 18 2018, 1:01 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Jan 8 2019, 4:20 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.
zeljkofilipin removed a project: Release-Engineering-Team (Kanban).
zeljkofilipin added a comment.Jan 8 2019, 4:22 PM

Should this task be resolved? Or does it depend on 471910 being merged? If it should not be resolved, should it be assigned to @Ephemeralwaves?

gerritbot added a comment.Jan 24 2019, 3:05 PM

Change 471910 abandoned by Zfilipin:
Test: notify a new user with welcome message

Reason:
implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/ /484712

https://gerrit.wikimedia.org/r/471910

zeljkofilipin assigned this task to Ephemeralwaves.Feb 22 2019, 5:23 PM

@Ephemeralwaves @Etonkovidova if this should be resolved, go ahead. :)

zeljkofilipin updated the task description. (Show Details)Feb 22 2019, 5:27 PM
zeljkofilipin updated the task description. (Show Details)
Ephemeralwaves closed this task as Resolved.Feb 25 2019, 4:02 PM
Etonkovidova updated the task description. (Show Details)Sep 24 2019, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL