Page MenuHomePhabricator

Add class to <pages /> tag output’s <div>
Closed, ResolvedPublic

Description

The <pages /> tag’s output is wrapped in a <div>. It would be nice to give it a CSS class, so that it can be found with TemplateStyles (and other) CSS. For example if the page numbers are shown on the left margin, the page number template could add some margin to have room for the numbers.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2018, 9:40 PM
Candalua triaged this task as Low priority.
Candalua added a subscriber: Candalua.

I'll do it as soon as I can. By looking at other css classes, I think a good, unambiguous name could be prp-pages-output.

Change 463566 had a related patch set uploaded (by Candalua; owner: Candalua):
[mediawiki/extensions/ProofreadPage@master] Add class to <pages /> tag output's <div>

https://gerrit.wikimedia.org/r/463566

Change 463566 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Add class to <pages /> tag output's <div>

https://gerrit.wikimedia.org/r/463566

Candalua closed this task as Resolved.Oct 6 2018, 8:28 AM

@Tacsipacsi: the class is now available as prp-pages-output.

Thanks, I’ve already used it, it works great!