Maniphest T205644

Improve Dashiki extension messaging
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Milimetric
	Sep 27 2018, 4:42 PM

Description

Add a link to Dashiki schema documentation
Make the message different depending on the type of configuration page

Details

	Subject	Repo	Branch	Lines +/-
	Fix problems with last change	mediawiki/extensions/Dashiki	master	+5 -3
	Improve messaging / help text	mediawiki/extensions/Dashiki	master	+42 -9

Customize query in gerrit

Related Objects

Mentioned In: rEDAH4ec8eb4b4193: Fix problems with last change
rEDAHdb450be86b89: Fix problems with last change
rEDAH3f6df3e7a187: Fix problems with last change
rEDAH23807874bc5d: Fix problems with last change
rEDAH4629567f6519: Fix problems with last change
rEDAHcefb34d8de0c: Improve messaging / help text

Event Timeline

Milimetric created this task.Sep 27 2018, 4:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2018, 4:42 PM

Milimetric triaged this task as High priority.Sep 27 2018, 4:42 PM

Milimetric moved this task from Incoming to Wikistats Beta on the Analytics board.

Milimetric moved this task from Next Up to In Code Review on the Analytics-Kanban board.

Change 463309 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[mediawiki/extensions/Dashiki@master] Improve messaging / help text

https://gerrit.wikimedia.org/r/463309

gerritbot added a project: Patch-For-Review.Sep 28 2018, 8:54 PM

Milimetric mentioned this in rEDAHcefb34d8de0c: Improve messaging / help text.Sep 28 2018, 8:57 PM

Change 463309 merged by Milimetric:
[mediawiki/extensions/Dashiki@master] Improve messaging / help text

https://gerrit.wikimedia.org/r/463309

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 8:01 PM

Change 464469 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[mediawiki/extensions/Dashiki@master] Fix problems with last change

https://gerrit.wikimedia.org/r/464469

Milimetric mentioned this in rEDAH4629567f6519: Fix problems with last change.Oct 4 2018, 2:15 AM

• Nuria moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Oct 4 2018, 4:09 PM

• Nuria moved this task from Ready to Deploy to In Code Review on the Analytics-Kanban board.Oct 4 2018, 4:11 PM

• Nuria moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Oct 5 2018, 4:11 PM

mforns set the point value for this task to 8.Oct 8 2018, 4:06 PM

mforns moved this task from Ready to Deploy to Done on the Analytics-Kanban board.

Is this deployed, mmessage does not seem to have chnaged? https://meta.wikimedia.org/w/index.php?title=Config:Dashiki:Annotations/Wikistats/newRegisteredUsers

• Nuria moved this task from Done to Ready to Deploy on the Analytics-Kanban board.Oct 8 2018, 7:27 PM

No, this isn't deployed. There are two gerrit changes:

https://gerrit.wikimedia.org/r/463309 implements the different messages, I self merged this and it has been auto-deployed to beta. It will be auto-deployed to production today. You can see it in action here: https://deployment.wikimedia.beta.wmflabs.org/wiki/Config:Dashiki:Annotations/Wikistats/Test1

https://gerrit.wikimedia.org/r/464469 will stay in review for a while until Lego gets around to it and we work out the cleanest way to do this. That's why this task is still in review. It's on the deployment train, but the code is still being polished according to mediawiki tradition and standards.

Milimetric moved this task from Ready to Deploy to In Code Review on the Analytics-Kanban board.Oct 9 2018, 2:26 PM

Milimetric mentioned this in rEDAH23807874bc5d: Fix problems with last change.Oct 17 2018, 5:59 PM

Milimetric mentioned this in rEDAH3f6df3e7a187: Fix problems with last change.

Milimetric mentioned this in rEDAHdb450be86b89: Fix problems with last change.Oct 17 2018, 6:41 PM

The first task that I self-merged is now deployed: https://meta.wikimedia.org/wiki/Config:Dashiki:Annotations/Wikistats/editors, so for our purposes this task is done. I'll continue to follow up with reviewers to merge my fixes to that first change.

• Nuria closed this task as Resolved.Oct 22 2018, 9:27 PM

• Nuria mentioned this in rEDAH4ec8eb4b4193: Fix problems with last change.Dec 14 2018, 11:29 PM

Change 464469 merged by jenkins-bot:
[mediawiki/extensions/Dashiki@master] Fix problems with last change