Page MenuHomePhabricator
Create Task
Maniphest T205794

"Thanked" sometimes not shown in revision history or diff-page (after restarting browser / session)
Closed, InvalidPublic
Actions

Description

Problem:
In Wikipedia it is possible to send other users Thanks notifications (see https://en.wikipedia.org/wiki/Wikipedia:Notifications/Thanks ). If you do this the button will change from "Thank" to "Thanked". However this is not always the case. I have come across multiple instances of Revision history pages or diff-pages ("Difference between revisions") where I know I have already thanked a user for a specific edit but the button is still shown as "Thank" while it should be shown as "Thanked".
Unfortunately I wasn't able to reproduce this error yet nor have I any idea what might be the cause of this.

Example:
I have not been able to reproduce this error yet.

Solution:
?

Event Timeline

Soluvo created this task.Sep 30 2018, 11:20 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 30 2018, 11:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Schniggendiller subscribed.Sep 30 2018, 1:42 PM

The thanks log does not record the specific edits. The information that you thanked user X for edit Y is stored in your browser session. If you restart your browser, there's again the "thanks" link instead of a "already thanked". And if you use another browser simultaneously, this one will not know that you thanked User X for the edit Y.

Soluvo added a comment.EditedOct 3 2018, 9:39 AM
In T205794#4627873, @Schniggendiller wrote:

The thanks log does not record the specific edits. The information that you thanked user X for edit Y is stored in your browser session. If you restart your browser, there's again the "thanks" link instead of a "already thanked". And if you use another browser simultaneously, this one will not know that you thanked User X for the edit Y.

Thanks for your reply. I understand that the current implementation is very beneficial for reasons of privacy since nobody can see for which specific edit a user was thanked (since edits might be controversial for whatever reasons). I wasn't aware of this aspect when I wrote the original post. I think it is important to keep this feature like it currently is (no changes).

Aklapper renamed this task from Sometimes "Thanked" is not shown in revision history or diff-page to "Thanked" sometimes not shown in revision history or diff-page (after restarting browser / session).Oct 3 2018, 10:50 AM
• Mholloway subscribed.Apr 7 2020, 10:53 PM

So it sounds like the extension is working as intended and this bug report should be closed as invalid?

Soluvo added a comment.Apr 10 2020, 1:12 PM

@Mholloway Yes, I think this issue can be closed.

• Mholloway closed this task as Invalid.Apr 10 2020, 2:15 PM

Done! And thanks for reporting, @Soluvo. This software behavior is indeed counter-intuitive; I came across this task while investigating a very similar issue.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL