Page MenuHomePhabricator
Create Task
Maniphest T206768

IndexLayout tab menu has wrong height in WikimediaUI (regression)
Closed, ResolvedPublic
Actions

Description

Height is 3em instead of 2.75em, see the white gap:

image.png (312×516 px, 14 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.29.3mediawiki/coremaster+531 -359
WikimediaUI theme: Fix specificity of IndexLayout overrideoojs/uimaster+7 -6
Customize query in gerrit

Event Timeline

Esanders created this task.Oct 11 2018, 3:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2018, 3:46 PM
gerritbot subscribed.Oct 11 2018, 4:01 PM

Change 466683 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Fix specificty of IndexLayout override

https://gerrit.wikimedia.org/r/466683

gerritbot added a project: Patch-For-Review.Oct 11 2018, 4:01 PM
Esanders added a comment.Oct 11 2018, 4:03 PM

After:

image.png (313×511 px, 12 KB)

gerritbot added a comment.Oct 11 2018, 5:04 PM

Change 466683 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Fix specificity of IndexLayout override

https://gerrit.wikimedia.org/r/466683

Volker_E renamed this task from IndexLayout tab menu has wrong height in WMUI (regression) to IndexLayout tab menu has wrong height in WikimediaUI (regression).Oct 11 2018, 7:22 PM
Volker_E closed this task as Resolved.
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.29.3 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.29.3); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Nov 1 2018, 2:59 AM

Change 470967 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.29.3

https://gerrit.wikimedia.org/r/470967

gerritbot added a project: Patch-For-Review.Nov 1 2018, 2:59 AM
gerritbot added a comment.Nov 1 2018, 3:59 AM

Change 470967 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.3

https://gerrit.wikimedia.org/r/470967

Volker_E removed a project: Patch-For-Review.Nov 2 2018, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL