Page MenuHomePhabricator
Create Task
Maniphest T206904

SVGMessageGroupTest::testImportTranslations is failing on PHP 7.2
Closed, ResolvedPublic
Actions

Description

00:06:43 1) SVGMessageGroupTest::testImportTranslations
00:06:43 count(): Parameter must be an array or an object that implements Countable
00:06:43 
00:06:43 /workspace/src/extensions/Translate/utils/MessageGroupStats.php:173
00:06:43 /workspace/src/extensions/TranslateSvg/tests/phpunit/SVGMessageGroupTest.php:92
00:06:43 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
00:06:43 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/557/consoleFull

Details

SubjectRepoBranchLines +/-
Fix testImportTranslations failing test in TranslateSvgmediawiki/extensions/TranslateREL1_31+4 -1
Fix testImportTranslations failing test in TranslateSvgmediawiki/extensions/Translatemaster+4 -1
Customize query in gerrit

Event Timeline

Legoktm created this task.Oct 13 2018, 7:16 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptOct 13 2018, 7:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to Other on the PHP 7.2 support board.Oct 14 2018, 2:42 AM
xSavitar claimed this task.Oct 14 2018, 12:52 PM
xSavitar triaged this task as Medium priority.
xSavitar added a project: MediaWiki-extensions-Translate.
xSavitar subscribed.

The error happens in the translate extension.

gerritbot subscribed.Oct 14 2018, 12:57 PM

Change 467120 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/Translate@master] Fix testImportTranslations failing test in TranslateSvg

https://gerrit.wikimedia.org/r/467120

gerritbot added a project: Patch-For-Review.Oct 14 2018, 12:57 PM
gerritbot added a comment.Oct 16 2018, 1:43 PM

Change 467120 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix testImportTranslations failing test in TranslateSvg

https://gerrit.wikimedia.org/r/467120

xSavitar closed this task as Resolved.Oct 16 2018, 1:53 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 16 2018, 2:01 PM
gerritbot added a comment.Jan 3 2021, 12:25 PM

Change 653736 had a related patch set uploaded (by Umherirrender; owner: Alangi Derick):
[mediawiki/extensions/Translate@REL1_31] Fix testImportTranslations failing test in TranslateSvg

https://gerrit.wikimedia.org/r/653736

Restricted Application added a project: User-xSavitar. · View Herald TranscriptJan 3 2021, 12:25 PM
gerritbot added a comment.Jan 3 2021, 12:49 PM

Change 653736 merged by jenkins-bot:
[mediawiki/extensions/Translate@REL1_31] Fix testImportTranslations failing test in TranslateSvg

https://gerrit.wikimedia.org/r/653736

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2021, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL