Page MenuHomePhabricator
Create Task
Maniphest T207386

Typo in docstring of wikibase js file causes file to be miscategorised in doc.wikimedia.org
Closed, ResolvedPublic
Actions

Description

There is a typo in the Wikibase extension here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/view/resources/jquery/wikibase/snakview/snakview.variations.SomeValue.js

This causes this file in the generated documentation to be miscategorised under "varaiations" instead of "variations" here:
https://doc.wikimedia.org/Wikibase/master/js/#!/api/jQuery.wikibase.snakview.varaiations.SomeValue

Fix the typo

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
jQuery snackview variation: Fixed typo errormediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Mvolz created this task.Oct 18 2018, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2018, 1:26 PM
Mvolz renamed this task from Typo in docstring of js file causes file to be miscategorised in doc.wikimedia.org to Typo in docstring of wikibase js file causes file to be miscategorised in doc.wikimedia.org.Oct 18 2018, 1:26 PM
Mvolz added a project: good first task.

I will mentor this in Google-Code-in-2018

Mvolz updated the task description. (Show Details)Oct 18 2018, 1:28 PM
Mvolz triaged this task as Low priority.Oct 18 2018, 1:36 PM
Liuxinyu970226 subscribed.Oct 21 2018, 1:50 AM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Oct 23 2018, 3:00 PM

https://codein.withgoogle.com/tasks/5635092983578624/

gerritbot subscribed.Oct 24 2018, 3:37 PM

Change 469430 had a related patch set uploaded (by JasMich.de; owner: JasMich.de):
[mediawiki/extensions/Wikibase@master] jQuery snackview variation: Fixed typo error

https://gerrit.wikimedia.org/r/469430

gerritbot added a project: Patch-For-Review.Oct 24 2018, 3:37 PM
gerritbot added a comment.Oct 26 2018, 5:06 PM

Change 469430 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] jQuery snackview variation: Fixed typo error

https://gerrit.wikimedia.org/r/469430

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 26 2018, 6:00 PM
Mvolz closed this task as Resolved.Nov 8 2018, 9:01 PM
Mvolz removed a project: Patch-For-Review.
Mvolz added a comment.Nov 8 2018, 9:05 PM

Done and deployed: https://doc.wikimedia.org/Wikibase/master/js/#!/api/jQuery.wikibase.snakview.variations

Liuxinyu970226 unsubscribed.Nov 11 2018, 6:46 AM
Mvolz mentioned this in T208226: wikibase termbox causing post-merge build failures in the jsduck build.Nov 12 2018, 10:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits