Maniphest T207746

[BUG] Search 3d touch shortcut doesn't work when already on the search tab in an article
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JoeWalsh
	Oct 23 2018, 1:27 PM

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

Open the search tab
Search for and navigate to an article
Exit the app to the home screen
3d touch and select "Search Wikipedia"

Expected results

Search shows

Actual results

Article shows

Environments observed

App version: 6.1 1505

Related Objects

Mentioned In: rAPIOS7e28eb0cd6dc: Merge pull request #2723 from wikimedia/fix/search-3d-touch-shortcut/T207746

Event Timeline

JoeWalsh created this task.Oct 23 2018, 1:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2018, 1:27 PM

JoeWalsh triaged this task as Medium priority.Oct 24 2018, 5:11 PM

JoeWalsh added a project: iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin.

JoeWalsh moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

If the visible view controller is an article view controller, push search onto the navigation stack (new behavior), otherwise switch to the search tab and activate search (current behavior)

Mhurd claimed this task.Oct 26 2018, 11:01 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.

https://github.com/wikimedia/wikipedia-ios/pull/2723

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Oct 27 2018, 6:08 AM

JoeWalsh mentioned this in rAPIOS7e28eb0cd6dc: Merge pull request #2723 from wikimedia/fix/search-3d-touch-shortcut/T207746.Oct 29 2018, 1:45 PM

Mhurd moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Oct 29 2018, 8:17 PM

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 5 2018, 7:36 PM

• JMinor moved this task from Needs Design Review to Needs QA on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 6 2018, 10:25 PM

Testing on iOS 12.1 (iPhone 7) and Wikipedia app 6.1.1 (1524). This is fixed as evidenced in a video I will share with @ABorbaWMF

Looks good to me on 6.1.1 (1524)

• JMinor closed this task as Resolved.Dec 3 2018, 7:29 PM

[BUG] Search 3d touch shortcut doesn't work when already on the search tab in an articleClosed, ResolvedPublicActions