Page MenuHomePhabricator
Create Task
Maniphest T208086

XTools doesn't handle URL-escaped slash correctly
Closed, ResolvedPublic
Actions

Description

Hi,

I noticed XTools doesn't handle URL-escaped slash in article's title correctly. Compare:

Examples with the Authorship tool:

We should have a look at our Apache config to find out why the request isn't getting forwarded to the application.

Related Objects

Event Timeline

Urbanecm created this task.Oct 26 2018, 6:50 PM
Framawiki subscribed.Oct 26 2018, 7:04 PM

See also T184712: Page.title(as_url=True) should encode also slashes.

MusikAnimal subscribed.Oct 26 2018, 7:04 PM
This comment was removed by MusikAnimal.
MusikAnimal updated the task description. (Show Details)Oct 26 2018, 7:12 PM
MusikAnimal moved this task from Backlog to General / other on the XTools board.
MusikAnimal added a comment.EditedOct 26 2018, 7:16 PM

Grr I'm stupid... thought I was looking at the URL for a different tool. The page you're trying to load DOES have a slash in it. Hence your bug report was completely valid, and forget what I said about formatting the URL correctly!

Same problem that I described though -- Apache isn't forwarding the request to the app. An oddity for sure.

MusikAnimal triaged this task as Low priority.Dec 6 2018, 5:38 AM
MusikAnimal mentioned this in T232775: Authorship tool fails for pages with a slash in the title.Sep 12 2019, 7:39 PM
MusikAnimal merged a task: T232775: Authorship tool fails for pages with a slash in the title.
MusikAnimal added a subscriber: CorrectHorseBatteryStaple.
MusikAnimal updated the task description. (Show Details)Sep 12 2019, 7:42 PM
Mjb subscribed.Dec 3 2019, 8:46 PM
MusikAnimal mentioned this in rXT250650547f84: Authorship, Blame: Allow page titles with slashes.Dec 10 2019, 12:55 AM
MusikAnimal mentioned this in T250489: WikiWho doesn't respect percent-encoded slashes.Apr 25 2020, 11:28 PM
MusikAnimal closed this task as Resolved.EditedMar 8 2022, 8:50 PM
MusikAnimal claimed this task.
MusikAnimal moved this task from General / other to Complete on the XTools board.

Fixed for non-API requests by adding the AllowEncodedSlashes On directive to the Apache config. It took me minutes to find the solution... sorry I didn't take the time to investigate 3+ years ago when this was reported!

Strangely the same issue still exists with the API, even though I updated the API server in the same way. That issue is being tracked at T301106. EDIT: I needed to use the nocanon option on the ProxyPass. Now fixed \o/

MusikAnimal mentioned this in T301106: Failed to load Articleinfo when the article begins with a slash.Mar 8 2022, 9:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL