Revision::fetchAllRevisions has LIMIT=1, thus not returning all revisions
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	May 17 2009, 9:00 AM

Description

Author: endlessoblivion

Description:
Revision::fetchAllRevisions (http://svn.wikimedia.org/doc/Revision_8php-source.html#l00205) does its work using Revision::fetchFromConds (http://svn.wikimedia.org/doc/Revision_8php-source.html#l00243), which has a fixed LIMIT=1 (http://svn.wikimedia.org/doc/Revision_8php-source.html#l00253), thus not returning all revisions, but only one of them.

Version: 1.16.x
Severity: minor

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:39 PM

• bzimport set Reference to bz18821.

• bzimport added a subscriber: Unknown Object (MLST).

The LIMIT=1 was added in r9211 in 2005...

Revision::fetchAllRevisions() appears to be unused, and well it should be unused as it would work very poorly on large pages. :)

Probably best fix is to kill the bad function.

Nuked it in r53339