Page MenuHomePhabricator

Provide search input label for assistive technology users
Closed, ResolvedPublic

Description

The search input doesn't provide any kind of label or label-helper markup for AT users:

<div class="search-box">
  <input class="search skin-minerva-search-trigger" type="search" name="search" id="searchInput" placeholder="Search Wikipedia" value="" readonly="">
</div>

Expected outcome:
aria-label provides a good compromise of markup needed and current screenreader support.

Event Timeline

Change 470542 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Provide ARIA label on main search input

https://gerrit.wikimedia.org/r/470542

Change 470545 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Provide ARIA label on main search input

https://gerrit.wikimedia.org/r/470545

Change 470545 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Provide ARIA label on main search input

https://gerrit.wikimedia.org/r/470545

Change 470542 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Provide ARIA label on main search input

https://gerrit.wikimedia.org/r/470542

@alexhollender over to you in case you are interested in checking the beta cluster. Please move out of sprint/resolve when you are done!

@Jdlrobson Another short reminder, that this label is currently set to the placeholder msg value. Should in a distant future somebody decide, that a placeholder isn't needed there, input description for AT users would disappear too.