Page MenuHomePhabricator
Create Task
Maniphest T208334

Add endorsement.timestamp field
Closed, ResolvedPublic
Actions

Description

Restore this field in the JADE content schema, support in the UI, tests and so on.

Details

SubjectRepoBranchLines +/-
Add endorsement.timestamp fieldmediawiki/extensions/JADEmaster+94 -5
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Oct 30 2018, 5:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2018, 5:11 PM
awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Oct 30 2018, 10:41 PM
gerritbot subscribed.Oct 30 2018, 10:41 PM

Change 470724 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/JADE@master] Add endorsement.timestamp field

https://gerrit.wikimedia.org/r/470724

gerritbot added a project: Patch-For-Review.Oct 30 2018, 10:41 PM
awight added a subscriber: Halfak.Oct 30 2018, 10:42 PM

@Halfak Let us know whether you agree that endorsement.timestamp should be required.

awight mentioned this in rEJADe8c750a63254: Add endorsement.timestamp field.Oct 30 2018, 10:44 PM
Harej moved this task from Inbox to In Progress on the Jade board.Oct 30 2018, 11:06 PM
Halfak added a comment.Nov 1 2018, 3:46 PM

My sense is that this should be required. I can't think of a good reason that it could be omitted.

gerritbot added a comment.Nov 2 2018, 12:09 AM

Change 470724 merged by jenkins-bot:
[mediawiki/extensions/JADE@master] Add endorsement.timestamp field

https://gerrit.wikimedia.org/r/470724

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 2 2018, 1:00 AM
awight closed this task as Resolved.Nov 14 2018, 10:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits